Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[opentitanlib] Refactor rescue protocol creation #26528

Open
wants to merge 3 commits into
base: earlgrey_1.0.0
Choose a base branch
from
Open

[opentitanlib] Refactor rescue protocol creation #26528

wants to merge 3 commits into from

Conversation

cfrantz
Copy link
Contributor

@cfrantz cfrantz commented Mar 5, 2025

  1. Refactor rescue into a trait.
  2. Refactor rescue protocol creation.
  3. Update the rusb crate.

@cfrantz cfrantz requested review from moidx and timothytrippel March 5, 2025 23:19
@cfrantz cfrantz requested a review from a team as a code owner March 5, 2025 23:19
@cfrantz cfrantz removed the request for review from a team March 5, 2025 23:19
moidx
moidx approved these changes Mar 5, 2025
View reviewed changes
Copy link
Contributor

@moidx moidx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

pamaury
pamaury reviewed Mar 6, 2025
View reviewed changes
sw/host/opentitanlib/src/rescue/mod.rs
pub enum RescueProtocol {
#[default]
Xmodem,
UsbDfu,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a USB implementation of the rescue protocol?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a prototype and have put an RFC on the agenda for the next Software WG meeting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pamaury pamaury pamaury left review comments

@moidx moidx moidx approved these changes

@timothytrippel timothytrippel Awaiting requested review from timothytrippel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cfrantz @pamaury @moidx