Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve temperature reading #50

Merged
merged 3 commits into from
Oct 5, 2024
Merged

Improve temperature reading #50

merged 3 commits into from
Oct 5, 2024

Conversation

adam-3bian
Copy link
Contributor

Show positive and negative temperatures in millidegrees Celsius according to page 28 of the AS621x Datasheet (DS000447v4).

Copy link
Contributor

@marnovandermaas marnovandermaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing this here! I haven't been able to test this yet, but was wondering what the white space changes are for?

@adam-3bian
Copy link
Contributor Author

Thanks for contributing this here! I haven't been able to test this yet, but was wondering what the white space changes are for?

Agreed, the indentation around Debug::log should not have changed. I've swapped my configuration to use clang-format.

Copy link
Member

@HU90m HU90m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great thank you!

For future me: the datasheet can be found here.

examples/all/i2c_example.cc Outdated Show resolved Hide resolved
adam-3bian and others added 2 commits October 5, 2024 16:42
Change conversion text to microdegrees

Co-authored-by: Hugo McNally <[email protected]>
@HU90m HU90m marked this pull request as ready for review October 5, 2024 16:01
@HU90m HU90m merged commit e1e8a75 into lowRISC:main Oct 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants