Remove resource limit

This patch removes the resource limit for test operator pods as we are hitting both issue when: - the limit is too low - the limit is too high (scheduler does not have enough resources) This is a hotfix before we expose the resource limit values through the test-operator CRs and find the correct default values. Related PRs: - openstack-k8s-operators#222 - openstack-k8s-operators#205
lpiwowar · Oct 9, 2024 · 6bdda49 · 6bdda49
1 parent f2ce22b
commit 6bdda49
Show file tree

Hide file tree

Showing 5 changed files with 0 additions and 19 deletions.
diff --git a/pkg/ansibletest/job.go b/pkg/ansibletest/job.go
@@ -64,9 +64,6 @@ func Job(
 							Env:             env.MergeEnvs([]corev1.EnvVar{}, envVars),
 							VolumeMounts:    GetVolumeMounts(mountCerts, instance, externalWorkflowCounter),
 							SecurityContext: &securityContext,
-							Resources: corev1.ResourceRequirements{
-								Limits: util.GetResourceLimits(),
-							},
 						},
 					},
 					Volumes: GetVolumes(

diff --git a/pkg/horizontest/job.go b/pkg/horizontest/job.go
@@ -63,9 +63,6 @@ func Job(
 							Env:             env.MergeEnvs([]corev1.EnvVar{}, envVars),
 							VolumeMounts:    GetVolumeMounts(mountCerts, mountKeys, mountKubeconfig, instance),
 							SecurityContext: &securityContext,
-							Resources: corev1.ResourceRequirements{
-								Limits: util.GetResourceLimits(),
-							},
 						},
 					},
 					Volumes: GetVolumes(

diff --git a/pkg/tempest/job.go b/pkg/tempest/job.go
@@ -79,9 +79,6 @@ func Job(
 									},
 								},
 							},
-							Resources: corev1.ResourceRequirements{
-								Limits: util.GetResourceLimits(),
-							},
 						},
 					},
 					Volumes: GetVolumes(

diff --git a/pkg/tobiko/job.go b/pkg/tobiko/job.go
@@ -68,9 +68,6 @@ func Job(
 							Env:             env.MergeEnvs([]corev1.EnvVar{}, envVars),
 							VolumeMounts:    GetVolumeMounts(mountCerts, mountKeys, mountKubeconfig, instance),
 							SecurityContext: &securityContext,
-							Resources: corev1.ResourceRequirements{
-								Limits: util.GetResourceLimits(),
-							},
 						},
 					},
 					Volumes: GetVolumes(

diff --git a/pkg/util/common.go b/pkg/util/common.go
@@ -38,10 +38,3 @@ func GetSecurityContext(
 
 	return securityContext
 }
-
-func GetResourceLimits() corev1.ResourceList {
-	return corev1.ResourceList{
-		corev1.ResourceCPU:    resource.MustParse("2000m"),
-		corev1.ResourceMemory: resource.MustParse("4Gi"),
-	}
-}