Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LLM: Add basic support for images #53

Closed
wants to merge 12 commits into from

Conversation

Hialus
Copy link
Member

@Hialus Hialus commented Feb 11, 2024

Motivation

In the future we want to support images in our LLM subsystem. This PR aims to introduce basic support for this.

Description

To add support for Images I added a new domain model IrisImage to represent images in a unified way.
I also added a basic wrapper for OpenAIs Dall-E to showcase how images can be created.
I also added support to pass images to Ollama models via normal and chat completion.

@Hialus Hialus self-assigned this Feb 11, 2024
@Hialus Hialus added the stacked-pr PR that depends on another PR label Feb 11, 2024
@Hialus Hialus added this to the 1.0.0-Prototype milestone Feb 11, 2024
Base automatically changed from feature/llm-subsystem-pydantic to main February 12, 2024 10:46
# Conflicts:
#	app/domain/__init__.py
#	app/domain/message.py
#	app/llm/llm_manager.py
#	app/llm/wrapper/__init__.py
#	app/llm/wrapper/abstract_llm_wrapper.py
#	app/llm/wrapper/ollama_wrapper.py
#	requirements.txt
@Hialus Hialus removed the stacked-pr PR that depends on another PR label Feb 14, 2024
yassinsws

This comment was marked as resolved.

Copy link
Contributor

@yassinsws yassinsws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add mime type to Iris image ? as it's specified in the url
also what is the use of raw data ? converting it to base64 if we don't get the base64 directly ?
image
image

@Hialus
Copy link
Member Author

Hialus commented Mar 6, 2024

Closed in favor of #77

@Hialus Hialus closed this Mar 6, 2024
@Hialus Hialus deleted the feature/llm/basic-image-support branch March 6, 2024 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants