Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Latest version of the test script. #100

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Latest version of the test script. #100

wants to merge 4 commits into from

Conversation

LR-inaf
Copy link
Collaborator

@LR-inaf LR-inaf commented Dec 11, 2023

Constrain on max displacement and user query to continue.

@LR-inaf LR-inaf requested a review from hdrass December 11, 2023 14:09
@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

hdrass
hdrass approved these changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@hdrass hdrass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Luca! Looks good!

@LR-inaf
Copy link
Collaborator Author

LR-inaf commented Jul 16, 2024

Please @teweitsai check the LVV-1782 test script and test it to the TTS, since I don't have access yet.

@teweitsai
Copy link
Collaborator

teweitsai commented Jul 16, 2024 •
edited
Loading

@hdrass and @pzorzi Please help to apply the authority of TTS for the INAF team to use. They would need this to be able to test the scripts. You would need Tiago's help to get so. Thanks!

gabrirod86
gabrirod86 requested changes Jul 17, 2024
View reviewed changes
Copy link
Collaborator

@gabrirod86 gabrirod86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the 3 missing cases for the angular coordinates, thanks!

gabrirod86
gabrirod86 approved these changes Jul 17, 2024
View reviewed changes
Copy link
Collaborator

@gabrirod86 gabrirod86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the code, the code has been tested on the TTS successfully for all the 6 DoFs.

gabrirod86
gabrirod86 approved these changes Jul 19, 2024
View reviewed changes
Copy link
Collaborator

@gabrirod86 gabrirod86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the units of measurement, the microrad was the unit of the M2 GUI, the CSC RBM commands work in arcsec, now the inconsistency has been cleared out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabrirod86 gabrirod86 gabrirod86 approved these changes

@hdrass hdrass hdrass approved these changes

@teweitsai teweitsai Awaiting requested review from teweitsai

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LR-inaf @teweitsai @hdrass @gabrirod86