DM-47189: Write default butler factory function for all instruments #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isullivan
approved these changes
Oct 28, 2024
| # it is present and blank, or just not set, both these exception | ||
| # types can be raised, see tests/test_butlerUtils.py:ButlerInitTestCase | ||
| # for details and tests which confirm these have not changed | ||
| raise FileNotFoundError # unify exception type |
There was a problem hiding this comment.
Do you want to include the original error message?
There was a problem hiding this comment.
This should be incredibly rare tbh. I almost removed this who try really - this was put in in the very very early days before we reliably had the $DAF_BUTLER_REPOSITORY_INDEX set at all our sites, and sometimes it was set but pointed to a file that was missing, etc etc. I suspect this will simply never happen now, so I think this is OK.
| ------- | ||
| butler : `lsst.daf.butler.Butler` | ||
| The butler. | ||
| """ |
There was a problem hiding this comment.
You could add a raises section for the FileNotFoundError handling.
There was a problem hiding this comment.
I will add the raises section for good measure though.
mfisherlevine
force-pushed
the
tickets/DM-47189
branch
from
72953d9
to
ef92e9a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.