DM-47269: Change fail behavior of getSite() and fix build breakage #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isullivan
approved these changes
Oct 29, 2024
| @@ -647,7 +644,7 @@ def getSite() -> str: | |||
| return "usdf-k8s" | |||
|
|
|||
| # we have failed | |||
| raise ValueError("Location could not be determined") | |||
| return "UNKOWN" | |||
There was a problem hiding this comment.
Note that butlerUtils and efdUtils each contain a try..except block that checks for ValueError. Suggest modifying those to remove the try..except or just ticketing the change.
There was a problem hiding this comment.
Thanks. Changed one, and ticketed the one that appears to be fine and I'm too scared to touch right now!
mfisherlevine
force-pushed
the
tickets/DM-47269
branch
from
6e84c3b
to
d05a360
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.