Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-46784: Add function for getting ecliptic coordinates #127

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

DM-46784: Add function for getting ecliptic coordinates #127

wants to merge 1 commit into from

Conversation

mfisherlevine
Copy link
Contributor

No description provided.

TallJimbo
TallJimbo approved these changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@TallJimbo TallJimbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know you probably can't do it now, but if you're reimplementing something from astropy for performance reasons, it's both particularly important and particularly easy to add a unit test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TallJimbo TallJimbo TallJimbo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mfisherlevine @TallJimbo