[DM-40656] Update dependencies / fix a bug #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbanek
changed the title
|
I'm not so sure about the content length of a 304... maybe I should just delete that header? It is true what that error message says. Although looking just now says that it should send what the body would have been? But then it seems like the framework would know better? Open to any thoughts on that one |
When serving a file that should be cached on the other side (and
crawlspace returns a 304) we return the Content-Length of the cached
file instead of the Content-Length of the 304 message. This makes
python emit the following error:
INFO: 68.230.27.252:40976 - "GET /api/hips/images/band_z/Norder11/Dir35540000/Npix35543833.png HTTP/1.1" 304 Not Modified
ERROR: Exception in ASGI application
Traceback (most recent call last):
File "/opt/venv/lib/python3.11/site-packages/uvicorn/protocols/http/httptools_impl.py", line 419, in run_asgi
result = await app( # type: ignore[func-returns-value]
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/opt/venv/lib/python3.11/site-packages/uvicorn/middleware/proxy_headers.py", line 78, in __call__
return await self.app(scope, receive, send)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/opt/venv/lib/python3.11/site-packages/fastapi/applications.py", line 270, in __call__
await super().__call__(scope, receive, send)
File "/opt/venv/lib/python3.11/site-packages/starlette/applications.py", line 124, in __call__
await self.middleware_stack(scope, receive, send)
File "/opt/venv/lib/python3.11/site-packages/starlette/middleware/errors.py", line 184, in __call__
raise exc
File "/opt/venv/lib/python3.11/site-packages/starlette/middleware/errors.py", line 162, in __call__
await self.app(scope, receive, _send)
File "/opt/venv/lib/python3.11/site-packages/starlette/middleware/base.py", line 107, in __call__
await response(scope, receive, send)
File "/opt/venv/lib/python3.11/site-packages/starlette/responses.py", line 266, in __call__
async with anyio.create_task_group() as task_group:
File "/opt/venv/lib/python3.11/site-packages/anyio/_backends/_asyncio.py", line 662, in __aexit__
raise exceptions[0]
File "/opt/venv/lib/python3.11/site-packages/starlette/responses.py", line 269, in wrap
await func()
File "/opt/venv/lib/python3.11/site-packages/starlette/responses.py", line 263, in stream_response
await send({"type": "http.response.body", "body": b"", "more_body": False})
File "/opt/venv/lib/python3.11/site-packages/starlette/middleware/errors.py", line 159, in _send
await send(message)
File "/opt/venv/lib/python3.11/site-packages/uvicorn/protocols/http/httptools_impl.py", line 561, in send
raise RuntimeError("Response content shorter than Content-Length")
RuntimeError: Response content shorter than Content-Length
Looking through the spec a bit more, it seems like it's okay to not
provide a content length and I think actually encouraged
https://datatracker.ietf.org/doc/html/rfc7232#section-4.1
cbanek
force-pushed
the
tickets/DM-40656
branch
from
e7da183
to
d1ab3e9
Compare
rra
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.