DM-47789: Move IP address normalization into a type #1172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using Pydantic `IPvAnyAddress` still appears to be more trouble than it's worth, but at least the internal IP address handling that produces a `str` can be moved into a Pydantic type rather than needing the more awkward field validator syntax.
Dual inheritance from `str` and `Enum` should generally be avoided in favor of `StrEnum`, but in the case of `HealthStatus` a simple enum is sufficient.
The `microseconds=True` argument to `current_datetime` makes it equivalent to the much shorter and standard `datetime.now(tz=UTC)`. Use the standard construction and reserve `current_datetime` for the cases where we want to suppress the microseconds field.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using Pydantic
IPvAnyAddressstill appears to be more trouble than it's worth, but at least the internal IP address handling that produces astrcan be moved into a Pydantic type rather than needing the more awkward field validator syntax.