Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cadc-tap log package from logLevelPackages & Add header to log4j.xml #112

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

stvoutsin
Copy link
Member

@stvoutsin stvoutsin commented Jul 24, 2024

Current setup produces a few warnings from the logging servlet, where it complains about a missing header in log4j.xml and a warning about a log message which should not be appearing. The second one is fixed by remove ca.nrc.cadc.log from the logLevelPackages in the web.xml configuration. A Doctype is added to address the first issue.

Copy link
Member

@rra rra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine -- I'm assuming that this CADC log package wasn't needed for any useful debugging logs or the like.

@stvoutsin stvoutsin merged commit a9e3e3d into master Jul 30, 2024
2 checks passed
@stvoutsin stvoutsin deleted the tickets/DM-45326 branch July 30, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants