Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-48413: Apply Times Square DB migration #4083

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
+6 −2
Draft

DM-48413: Apply Times Square DB migration #4083

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
083de0c
Apply DM-48413 Times Square DB migration on idfdev
jonathansick Jan 14, 2025
5e62a46
Use helper variable for serviceAccountName
jonathansick Jan 14, 2025
075e105
Use alpine version of sql proxy for schema updates
jonathansick Jan 14, 2025
1c154b5
Drop schema update on idfev
jonathansick Jan 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion applications/times-square/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ sources:
type: application

# The default version tag of the times-square docker image
appVersion: "0.14.0"
appVersion: "tickets-DM-48413"

dependencies:
- name: redis
Expand Down
1 change: 1 addition & 0 deletions applications/times-square/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ An API service for managing and rendering parameterized Jupyter notebooks.
| cloudsql.image.pullPolicy | string | `"IfNotPresent"` | Pull policy for Cloud SQL Auth Proxy images |
| cloudsql.image.repository | string | `"gcr.io/cloudsql-docker/gce-proxy"` | Cloud SQL Auth Proxy image to use |
| cloudsql.image.resources | object | see `values.yaml` | Resource requests and limits for Cloud SQL pod |
| cloudsql.image.schemaUpdateTagSuffix | string | `"-alpine"` | Tag suffix to use for the proxy for schema updates |
| cloudsql.image.tag | string | `"1.37.3"` | Cloud SQL Auth Proxy tag to use |
| cloudsql.instanceConnectionName | string | `""` | Instance connection name for a Cloud SQL PostgreSQL instance |
| cloudsql.serviceAccount | string | `""` | The Google service account that has an IAM binding to the `times-square` Kubernetes service accounts and has the `cloudsql.client` role |
Expand Down
2 changes: 1 addition & 1 deletion applications/times-square/templates/job-schema-update.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ spec:
times-square-redis-client: "true"
spec:
{{- if .Values.cloudsql.enabled }}
serviceAccountName: "times-square"
serviceAccountName: {{ include "times-square.serviceAccountName" . }}
{{- else }}
automountServiceAccountToken: false
{{- end }}
Expand Down
3 changes: 3 additions & 0 deletions applications/times-square/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,9 @@ cloudsql:
# -- Cloud SQL Auth Proxy tag to use
tag: "1.37.3"

# -- Tag suffix to use for the proxy for schema updates
schemaUpdateTagSuffix: "-alpine"

# -- Pull policy for Cloud SQL Auth Proxy images
pullPolicy: "IfNotPresent"

Expand Down
Loading