DM-47027: Change get param dependency to correctly parse list params #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rra
approved these changes
Oct 22, 2024
stvoutsin
force-pushed
the
tickets/DM-47027
branch
from
ccdf717
to
0e291db
Compare
|
Just made one minor change to add the test route on its own "/test" prefix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
GET & POST list params were not being read correctly, i.e. providing multiple "POS" params. Reason is that we were using
request.query_params.items() instead of request.query_params.multi_items()
This fix has been tested and does now correctly read in list params.
Tests
A test case has been added which introduces a simple route that returns the params that were provided as a json response.
Not sure if there is a better way to do this?