Fix SpanSet Creation from large circles

Fix an issue where data-types were not large enough to hold values that may be plausibly used.
lsst · Feb 7, 2023 · 95cf2c2 · 95cf2c2
1 parent 4d73512
commit 95cf2c2
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/src/geom/SpanSet.cc b/src/geom/SpanSet.cc
@@ -691,9 +691,13 @@ std::shared_ptr<SpanSet> SpanSet::fromShape(int r, Stencil s, lsst::geom::Point2
     tempVec.reserve(2 * r + 1);
     switch (s) {
         case Stencil::CIRCLE:
-            for (auto dy = -r; dy <= r; ++dy) {
-                int dx = static_cast<int>(sqrt(r * r - dy * dy));
-                tempVec.emplace_back(dy + offset.getY(), -dx + offset.getX(), dx + offset.getX());
+            {
+                double dr = static_cast<double>(r);
+                dr *= dr;
+                for (auto dy = std::make_pair<int, double>(-r, -r); dy.first <= r; ++dy.first, ++dy.second) {
+                    int dx = static_cast<int>(sqrt(dr-(dy.second*dy.second)));
+                    tempVec.emplace_back(dy.first + offset.getY(), -dx + offset.getX(), dx + offset.getX());
+                }
             }
             break;
         case Stencil::MANHATTAN: