Spectro flat and mask to improve spectral extraction #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremyneveu
commented
Apr 10, 2024
python/lsst/atmospec/spectraction.py
Outdated
| image.gain = self._setGainFromExp(image, exp, .85) # gain required for calculating stat err | ||
| import lsst.daf.butler as dafButler | ||
| # butler = dafButler.Butler("/sdf/group/rubin/repo/oga/", collections=['LATISS/calib','LATISS/raw/all']) | ||
| butler = dafButler.Butler("/repo/embargo", collections=['LATISS/calib','LATISS/raw/all']) |
There was a problem hiding this comment.
This initialisation of the butler with hardcoded paths is probably not what I should do but I don't know how to make it nicer.
mfisherlevine
force-pushed
the
u/jneveu/doFlat
branch
from
74ed1e4
to
93baef9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to propose an upgrade of atmospec to adapt to new v3.1.0 Spectractor version and add:
There are some code lines that makes butler call in a non-ideal way that needs to be adapted.