DM-46509: Add FULLCOVRIANCE_NO_B fit option to PTC solver #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erykoff
requested changes
Oct 15, 2024
Alex-Broughton
force-pushed
the
tickets/DM-46509
branch
from
f6995f5
to
6cf0085
Compare
|
My comment above is still a problem. If the file has these columns we want to read them in; when that is done it shouldn't issue a deprecation warning, but if you try to access them it will (but will have values!) |
erykoff
reviewed
Nov 4, 2024
| inDict['covariancesModel'][ampName], | ||
| np.nan, | ||
| ) | ||
| inDict['aMatrixNoB'][ampName] = np.full_like(inDict['aMatrix'][ampName], np.nan) |
There was a problem hiding this comment.
I don't know if this else is necessary. For newer PTCs we shouldn't be using these fields at all, right?
| partialPtc.covariancesModelNoB[ampName].ravel() | ||
| self._covariancesModelNoB[ampName] = np.append( | ||
| self._covariancesModelNoB[ampName].ravel(), | ||
| partialPtc._covariancesModelNoB[ampName].ravel() |
There was a problem hiding this comment.
We aren't using this at all; I think if we need filler this should be explicitly filled with nans.
Alex-Broughton
force-pushed
the
tickets/DM-46509
branch
from
25da546
to
5cd6120
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.