Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-47449: Replace afw akima interpolator with scipy for speed. #361

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

DM-47449: Replace afw akima interpolator with scipy for speed. #361

wants to merge 2 commits into from

Conversation

erykoff
Copy link
Contributor

@erykoff erykoff commented Nov 7, 2024

No description provided.

czwa
czwa approved these changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@czwa czwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason to keep the AFW interpolator in tests/mocks? I'm fine with it, but wanted to ask.

@erykoff
Copy link
Contributor Author

erykoff commented Nov 7, 2024

I wanted to leave it there as a cheap way of testing consistency. I thought I put this in the comments. Anyway, I deliberately said "use afw to alter the image and scipy to correct it" and everything works fine as long as you stay away from extrapolation (which we should).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czwa czwa czwa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erykoff @czwa