add ascom author style #1221
Merged
add ascom author style #1221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
womullan
force-pushed
the
tickets/DM-46066
branch
from
63f703c
to
da62560
Compare
timj
approved these changes
Aug 30, 2024
bin/db2authors.py
Outdated
| @@ -178,7 +182,10 @@ def get_initials(initials): | |||
| if args.noafil: | |||
| affilAuth = affilAuth | |||
| else: | |||
| affilAuth = auth_afil_form.format(affilAuth, affilSep, str(affilInd)) | |||
| if args.mode == "ascom": | |||
There was a problem hiding this comment.
could do elif args.mode == "ascom": here so it wouldn't indent further.
bin/db2authors.py
Outdated
| @@ -235,7 +243,10 @@ def get_initials(initials): | |||
| indexOutput.append(rf"%\aindex{{{surname},{justInitials}}}") | |||
|
|
|||
| if buffer_authors: | |||
| authOutput.append(author_form.format(initials, surname, affilAuth)) | |||
| if args.mode == "ascom": | |||
| authOutput.append(author_form.format(affilAuth, initials, surname)) | |||
There was a problem hiding this comment.
The code could be simplified a lot if we put key names in the format strings and then used kwargs with format. eg
>>> f = "affiliation: {affil} author: {author}"
>>> f.format(author="Wil", affil="Rubin")
'affiliation: Rubin author: Wil'Then you wouldn't need to have the if statement here or earlier because the order in the format method wouldn't matter anyhow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.