Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BPM. #1290

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add BPM. #1290

wants to merge 4 commits into from

Conversation

ktlim
Copy link
Contributor

@ktlim ktlim commented Nov 13, 2024

No description provided.

@ktlim ktlim requested a review from womullan November 13, 2024 16:05
Copy link
Member

@womullan womullan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add spanish also ? (trying to keep it complete)
Mapa de píxeles defectuoso

@ktlim ktlim force-pushed the u/ktl/add-bpm branch 2 times, most recently from d0885cb to a729082 Compare November 13, 2024 19:05
@ktlim
Copy link
Contributor Author

ktlim commented Nov 13, 2024

@womullan OK, done (and some syntax problems fixed).

Copy link
Member

@womullan womullan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for catching the comma;s .. i guess i should have a check for that like i do in english

@@ -126,7 +127,7 @@ CA,Cuenta de control (o costo),
CAA,Comité de Astronomía y Astrofísica (NSF),
CADC,Centro Canadiense de Datos Astronómicos,
CALTECH,Instituto Tecnológico de California,
CAM,CÁMara,DM
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you remove the tag from here it will break the translation - CAM is overloaded and the TAG breaks the confusion of which translation to use. SO either we put CAM on both or with put DM on both it can not be blank - most docs use DM as default and usually we will want Camera not Control Account Manager .. I would be ok tagging Camera at "Gen" and Control Account Manager as "PMO" but it must be consistent in both english and spanish files

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like we need a linter to make sure tags match up and that identical items have different tags...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, or did it check and I missed the failure?

@@ -814,7 +815,7 @@ OSHA,Administración de Seguridad y Salud Ocupacional de los EE. UU.,
OSI,interconexión de sistemas abiertos,
OSPF,"Open Short Path First [«Abrir el camino más corto primero», protocolo de red]",
OSPL,OpenSplice DDS - sistema de mensajería subyacente para SAL,
OSS,Especificaciones del sistema de observatorios; LSE-30,DM
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same issue - tags have to match

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted these.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants