Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add modelSize to piff config #23

Merged
merged 5 commits into from
Apr 12, 2024

Commits on Apr 4, 2024

  1. add modelSize to piff config

    The modelSize is the internal PIFF model grid size.  This gets
    sent to the piff config rather than stampSize for the "size" entry.
    
    modelSize defaults to 25. Update the stampSize to default to sqrt(2) * 25 ~ 35
    to accomodate rotations
    
    Add a check that stamp size is big enough
    esheldon committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    e051711 View commit details
    Browse the repository at this point in the history
  2. update tests to include rotation

    This is an important check when working in sky coords
    
    Oddly at 45 degrees piff is giving a singlular matrix error
    and fails to fit.  We should track this down before accepting
    this PR.  135 works fine so I wonder if there is something
    sepcial about 45 for this test
    esheldon committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    7fe21e9 View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2024

  1. use property list to convert to galsim wcs

    Will work for FITS wcs
    esheldon committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    6d16110 View commit details
    Browse the repository at this point in the history
  2. revert to using CelestialWcsWrapper

    We think its an issue with the underlying galsim code
    rather than the wrapper
    esheldon committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    cb3fe08 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2024

  1. Configuration menu
    Copy the full SHA
    5529420 View commit details
    Browse the repository at this point in the history