Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-44467: Merge the 45-degree special case test with the rest #29

Merged
merged 1 commit into from
Aug 30, 2024
Merged

DM-44467: Merge the 45-degree special case test with the rest #29

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 1 addition & 12 deletions tests/test_psf.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -502,25 +502,14 @@ def testPiffDeterminer_skyCoords(self):

self.checkPiffDeterminer(useCoordinates='sky')

@lsst.utils.tests.methodParameters(angle_degrees=[0, 35, 77, 135])
@lsst.utils.tests.methodParameters(angle_degrees=[0, 35, 45, 77, 135])
def testPiffDeterminer_skyCoords_with_rotation(self, angle_degrees):
"""Test Piff sky coords with rotation."""

wcs = make_wcs(angle_degrees=angle_degrees)
self.exposure.setWcs(wcs)
self.checkPiffDeterminer(useCoordinates='sky', kernelSize=35)

# TODO: Merge this case with the above in DM-44467.
@unittest.skipUnless(Version(galsim.version) >= Version("2.5.2"),
reason="Requires GalSim >= 2.5.2",
)
def testPiffDeterminer_skyCoords_rot45(self):
"""Test Piff sky coords."""

wcs = make_wcs(angle_degrees=45)
self.exposure.setWcs(wcs)
self.checkPiffDeterminer(useCoordinates='sky', kernelSize=35)

def testPiffDeterminer_skyCoords_failure(self, angle_degrees=135):
"""Test that using small PSF candidates with sky coordinates fails."""
wcs = make_wcs(angle_degrees=angle_degrees)
Expand Down
Loading