black + manual cleanup of flake8 errors

config/assembleCoadd.py

@@ -22,15 +22,16 @@
 
 import os.path
 
+from lsst.pipe.tasks.selectImages import PsfWcsSelectImagesTask
+
 # Load configs shared between assembleCoadd and makeCoaddTempExp
 config.load(os.path.join(os.path.dirname(__file__), "coaddBase.py"))
 
-config.subregionSize = (10000, 200) # 200 rows (since patch width is typically < 10k pixels)
+config.subregionSize = (10000, 200)  # 200 rows (since patch width is typically < 10k pixels)
 config.removeMaskPlanes.append("CROSSTALK")
 config.doNImage = True
 config.badMaskPlanes += ["SUSPECT"]
 
-from lsst.pipe.tasks.selectImages import PsfWcsSelectImagesTask
 config.select.retarget(PsfWcsSelectImagesTask)
 
 # FUTURE: Set to True when we get transmission curves

config/cmodel.py

@@ -20,8 +20,8 @@
 # the GNU General Public License along with this program.  If not,
 # see <http://www.lsstcorp.org/LegalNotices/>.
 
-import os
-import lsst.meas.modelfit
+import lsst.meas.modelfit  # noqa: F401 required to use modelfit plugin below
+
 config.measurement.plugins.names |= ["modelfit_DoubleShapeletPsfApprox", "modelfit_CModel"]
-config.measurement.slots.modelFlux = 'modelfit_CModel'
-config.catalogCalculation.plugins['base_ClassificationExtendedness'].fluxRatio = 0.985
+config.measurement.slots.modelFlux = "modelfit_CModel"
+config.catalogCalculation.plugins["base_ClassificationExtendedness"].fluxRatio = 0.985

config/coaddDriver_noPSF.py

@@ -21,4 +21,5 @@
 # see <http://www.lsstcorp.org/LegalNotices/>.
 
 from lsst.pipe.tasks.selectImages import WcsSelectImagesTask
+
 config.select.retarget(WcsSelectImagesTask)

config/comCamSim/analysisToolsPhotometricCatalogMatch.py

@@ -1,8 +1,9 @@
 """comCamSim-specific overrides for PhotometricCatalogMatchTask"""
 
 import os.path
+
 configDir = os.path.dirname(__file__)
-config.referenceCatalogLoader.refObjLoader.load(os.path.join(configDir, 'filterMap.py'))
+config.referenceCatalogLoader.refObjLoader.load(os.path.join(configDir, "filterMap.py"))
 config.referenceCatalogLoader.doApplyColorTerms = False
 
 config.connections.refCatalog = "uw_stars_20240524"

config/comCamSim/analysisToolsPhotometricCatalogMatchVisit.py

@@ -1,8 +1,9 @@
 """comCamSim-specific overrides for PhotometricCatalogMatchVisitTask"""
 
 import os.path
+
 configDir = os.path.dirname(__file__)
-config.referenceCatalogLoader.refObjLoader.load(os.path.join(configDir, 'filterMap.py'))
+config.referenceCatalogLoader.refObjLoader.load(os.path.join(configDir, "filterMap.py"))
 
 config.connections.refCatalog = "uw_stars_20240524"
 config.referenceCatalogLoader.doApplyColorTerms = False

config/comCamSim/computeExposureSummaryStats.py

@@ -7,30 +7,30 @@
 
 # Fiducial PsfSigma in pixels
 config.fiducialPsfSigma = {
-    'u': 1.72,
-    'g': 1.63,
-    'r': 1.56,
-    'i': 1.51,
-    'z': 1.47,
-    'y': 1.44,
+    "u": 1.72,
+    "g": 1.63,
+    "r": 1.56,
+    "i": 1.51,
+    "z": 1.47,
+    "y": 1.44,
 }
 
 # Fiducial ZeroPoint for 1s exposure
 config.fiducialZeroPoint = {
-    'u': 25.96,
-    'g': 27.95,
-    'r': 27.80,
-    'i': 27.61,
-    'z': 27.22,
-    'y': 26.26,
+    "u": 25.96,
+    "g": 27.95,
+    "r": 27.80,
+    "i": 27.61,
+    "z": 27.22,
+    "y": 26.26,
 }
 
 # Fiducial SkyBackground in ADU per second
 config.fiducialSkyBackground = {
-    'u': 0.90,
-    'g': 9.20,
-    'r': 19.62,
-    'i': 31.51,
-    'z': 47.26,
-    'y': 53.91,
+    "u": 0.90,
+    "g": 9.20,
+    "r": 19.62,
+    "i": 31.51,
+    "z": 47.26,
+    "y": 53.91,
 }

config/comCamSim/fgcmFitCycle.py

@@ -17,7 +17,7 @@
 config.maxIterBeforeFinalCycle = 50
 config.minCcdPerExp = 1
 config.utBoundary = 0.0
-config.washMjds = (0.0, )
+config.washMjds = (0.0,)
 # For now, define 1 observing epoch that encompasses everything.
 config.epochMjds = (0.0, 100000.0)
 config.coatingMjds = []

config/comCamSim/fgcmMakeLut.py

@@ -6,4 +6,4 @@
 ]
 
 # FGCM name or filename of precomputed atmospheres
-config.atmosphereTableName = 'fgcm_atm_lsst2'
+config.atmosphereTableName = "fgcm_atm_lsst2"

config/comCamSim/gbdesAstrometricFit.py

@@ -3,6 +3,6 @@
 """
 config.connections.referenceCatalog = "uw_stars_20240524"
 config.applyRefCatProperMotion = False
-config.referenceFilter = 'lsst_r'
+config.referenceFilter = "lsst_r"
 config.devicePolyOrder = 5
 config.exposurePolyOrder = 7

config/convolvedFluxes.py

@@ -20,6 +20,7 @@
 # the GNU General Public License along with this program.  If not,
 # see <http://www.lsstcorp.org/LegalNotices/>.
 
-import lsst.meas.extensions.convolved  # noqa: Load flux.convolved algorithm
+import lsst.meas.extensions.convolved  # noqa: F401 required to use ConvolvedFlux below
+
 config.plugins.names.add("ext_convolved_ConvolvedFlux")
 config.plugins["ext_convolved_ConvolvedFlux"].seeing.append(8.0)

config/findDefects.py

@@ -1,4 +1,4 @@
 import os.path
 
 config.load(os.path.join(os.path.dirname(__file__), "lsstCamCommon.py"))
-config.ccdKey = 'detector'
+config.ccdKey = "detector"

config/forcedPhotCoadd.py

@@ -22,8 +22,6 @@
 
 import os.path
 
-from lsst.meas.base import CircularApertureFluxAlgorithm
-
 config.measurement.load(os.path.join(os.path.dirname(__file__), "apertures.py"))
 config.measurement.load(os.path.join(os.path.dirname(__file__), "kron.py"))
 config.measurement.load(os.path.join(os.path.dirname(__file__), "convolvedFluxes.py"))
@@ -35,6 +33,7 @@
 config.catalogCalculation.plugins.names = ["base_ClassificationExtendedness"]
 config.measurement.slots.psfFlux = "base_PsfFlux"
 
+
 def doUndeblended(config, algName, fluxList=None):
     """Activate undeblended measurements of algorithm
     Parameters

config/gaap.py

@@ -20,7 +20,8 @@
 # the GNU General Public License along with this program.  If not,
 # see <http://www.lsstcorp.org/LegalNotices/>.
 
-import lsst.meas.extensions.gaap  # noqa: Load GAaP algorithm
+import lsst.meas.extensions.gaap  # noqa: F401 required to use GaapFlux below
+
 config.plugins.names.add("ext_gaap_GaapFlux")
 config.plugins["ext_gaap_GaapFlux"].sigmas = [0.5, 0.7, 1.0, 1.5, 2.5, 3.0]
 # Enable PSF photometry after PSF-Gaussianization in the `ext_gaap_GaapFlux` plugin

config/imsim/analysisToolsPhotometricCatalogMatch.py

@@ -1,5 +1,6 @@
 import os.path
+
 configDir = os.path.dirname(__file__)
-config.referenceCatalogLoader.refObjLoader.load(os.path.join(configDir, 'filterMap.py'))
+config.referenceCatalogLoader.refObjLoader.load(os.path.join(configDir, "filterMap.py"))
 
 config.referenceCatalogLoader.doApplyColorTerms = False

config/imsim/analysisToolsPhotometricCatalogMatchVisit.py

@@ -1,5 +1,6 @@
 import os.path
+
 configDir = os.path.dirname(__file__)
-config.referenceCatalogLoader.refObjLoader.load(os.path.join(configDir, 'filterMap.py'))
+config.referenceCatalogLoader.refObjLoader.load(os.path.join(configDir, "filterMap.py"))
 
 config.referenceCatalogLoader.doApplyColorTerms = False

config/imsim/calibrate.py

@@ -29,8 +29,8 @@
 # imSim-specifc reference catalog configuration.
 config.connections.astromRefCat = "cal_ref_cat"
 config.connections.photoRefCat = "cal_ref_cat"
-config.astromRefObjLoader.load(os.path.join(configDir, 'filterMap.py'))
-config.photoRefObjLoader.load(os.path.join(configDir, 'filterMap.py'))
+config.astromRefObjLoader.load(os.path.join(configDir, "filterMap.py"))
+config.photoRefObjLoader.load(os.path.join(configDir, "filterMap.py"))
 config.astromRefObjLoader.anyFilterMapsToThis = None
 
 # Reduce Chebyshev polynomial order for background fitting (DM-30820)

config/imsim/calibrateImage.py

@@ -18,9 +18,9 @@
 config.connections.astrometry_ref_cat = "cal_ref_cat_2_2"
 config.connections.photometry_ref_cat = "cal_ref_cat_2_2"
 # Use the ImSim filterMap ("lsst_X_smeared" reference fluxes).
-config.astrometry_ref_loader.load(os.path.join(config_dir, 'filterMap.py'))
+config.astrometry_ref_loader.load(os.path.join(config_dir, "filterMap.py"))
 config.astrometry_ref_loader.anyFilterMapsToThis = None
-config.photometry_ref_loader.load(os.path.join(config_dir, 'filterMap.py'))
+config.photometry_ref_loader.load(os.path.join(config_dir, "filterMap.py"))
 
 # Make sure galaxies from truth catalog are not used for calibration.
 config.astrometry.referenceSelector.doUnresolved = True

config/imsim/filterMap.py

@@ -20,4 +20,4 @@
 # the GNU General Public License along with this program.  If not,
 # see <http://www.lsstcorp.org/LegalNotices/>.
 
-config.filterMap = {band: 'lsst_%s_smeared' % (band) for band in 'ugrizy'}
+config.filterMap = {band: "lsst_%s_smeared" % (band) for band in "ugrizy"}

config/imsim/isr.py

@@ -22,5 +22,5 @@
 """
 imsim-specific overrides for IsrTask
 """
-config.connections.newBFKernel = "bfk" 
+config.connections.newBFKernel = "bfk"
 config.doBrighterFatter = True

config/kron.py

@@ -20,5 +20,6 @@
 # the GNU General Public License along with this program.  If not,
 # see <http://www.lsstcorp.org/LegalNotices/>.
 
-import lsst.meas.extensions.photometryKron
+import lsst.meas.extensions.photometryKron  # noqa: F401 required to use KronFlux below
+
 config.plugins.names |= ["ext_photometryKron_KronFlux"]

config/latiss/assembleCoadd.py

@@ -21,13 +21,13 @@
 # see <http://www.lsstcorp.org/LegalNotices/>.
 
 # AuxTel PSF is not stable at this time resulting in many frames being
-# rejected by standard psfWcsSelect. Switch to using WcsSelectImagesTask 
+# rejected by standard psfWcsSelect. Switch to using WcsSelectImagesTask
 # to avoid rejecting too many frames.
 
 import os.path
+from lsst.pipe.tasks.selectImages import WcsSelectImagesTask
 
 # Load configs shared between assembleCoadd and makeWarp.
 config.load(os.path.join(os.path.dirname(__file__), "coaddBase.py"))
 
-from lsst.pipe.tasks.selectImages import WcsSelectImagesTask
 config.select.retarget(WcsSelectImagesTask)

config/latiss/associatedSourcesTractAnalysis.py

@@ -4,4 +4,4 @@
 # By default loop over all the same bands that are present in the Object Table
 objectConfig = TransformObjectCatalogConfig()
 objectConfig.load(os.path.join(os.path.dirname(__file__), "transformObjectCatalog.py"))
-config.bands = objectConfig.outputBands
+config.bands = objectConfig.outputBands

config/latiss/calibrate.py

@@ -14,7 +14,7 @@
 colors["g-r"] = ColorLimit(primary="g_flux", secondary="r_flux", minimum=0.4, maximum=2.0)
 
 config.photoCal.applyColorTerms = True
-config.photoCal.photoCatName="atlas_refcat2_20220201"
+config.photoCal.photoCatName = "atlas_refcat2_20220201"
 config.photoCal.colorterms.load(os.path.join(ObsConfigDir, "colorterms.py"))
 
 # We often have very few sources due to smaller aperture so use affine task.
@@ -44,14 +44,14 @@
 config.astrometry.matcher.maxRotationDeg = 2.0
 
 config.astrometry.sourceFluxType = "Psf"
-config.astrometry.sourceSelector['matcher'].sourceFluxType = "Psf"
-config.astrometry.sourceSelector['matcher'].minSnr = 10
+config.astrometry.sourceSelector["matcher"].sourceFluxType = "Psf"
+config.astrometry.sourceSelector["matcher"].minSnr = 10
 
 config.measurement.plugins["base_Jacobian"].pixelScale = 0.1
 
 # Set the default aperture as appropriate for the LATISS plate scale.
 config.measurement.algorithms["base_CompensatedTophatFlux"].apertures = [35]
 config.normalizedCalibrationFlux.raw_calibflux_name = "base_CompensatedTophatFlux_35"
 
-config.measurement.slots.apFlux='base_CircularApertureFlux_35_0'
-config.measurement.slots.calibFlux='base_CircularApertureFlux_35_0'
+config.measurement.slots.apFlux = "base_CircularApertureFlux_35_0"
+config.measurement.slots.calibFlux = "base_CircularApertureFlux_35_0"

config/latiss/calibrateImage.py

@@ -20,7 +20,7 @@
 config.psf_measure_psf.psfDeterminer["psfex"].stampSize = 71
 
 config.install_simple_psf.width = 21
-config.install_simple_psf.fwhm = 2.355*2  # LATISS plate scale is 2x LSST nominal
+config.install_simple_psf.fwhm = 2.355 * 2  # LATISS plate scale is 2x LSST nominal
 
 # Turn off S/N cut for aperture correction measurement source selection
 # (it now only includes calib_psf_used objects, and that cut is "good
@@ -36,7 +36,7 @@
 colors["g-r"] = ColorLimit(primary="g_flux", secondary="r_flux", minimum=0.4, maximum=2.0)
 
 config.photometry.applyColorTerms = True
-config.photometry.photoCatName="atlas_refcat2_20220201"
+config.photometry.photoCatName = "atlas_refcat2_20220201"
 config.photometry.colorterms.load(os.path.join(config_dir, "colorterms.py"))
 
 # Note that the following two config values were validated on data taken in
@@ -64,5 +64,5 @@
 
 # Set the default aperture as appropriate for the LATISS plate scale.
 config.star_measurement.plugins["base_CircularApertureFlux"].radii = [35.0]
-config.star_measurement.slots.apFlux = 'base_CircularApertureFlux_35_0'
-config.star_measurement.slots.calibFlux = 'base_CircularApertureFlux_35_0'
+config.star_measurement.slots.apFlux = "base_CircularApertureFlux_35_0"
+config.star_measurement.slots.calibFlux = "base_CircularApertureFlux_35_0"

config/latiss/characterizeImage.py

@@ -20,7 +20,7 @@
 config.measurePsf.psfDeterminer["psfex"].stampSize = 71
 
 config.installSimplePsf.width = 21
-config.installSimplePsf.fwhm = 2.355*2  # LATISS plate scale is 2x LSST nominal
+config.installSimplePsf.fwhm = 2.355 * 2  # LATISS plate scale is 2x LSST nominal
 
 # Turn off S/N cut for aperture correction measurement source selection
 # (it now only includes calib_psf_used objects, and that cut is "good
@@ -36,7 +36,11 @@
 # As above, turn off S/N cut for aperture correction source selection.
 config.normalizedCalibrationFlux.measure_ap_corr.sourceSelector["science"].doSignalToNoise = False
 # Put in the correct override fields in case we revisit this in the future.
-config.normalizedCalibrationFlux.measure_ap_corr.sourceSelector["science"].signalToNoise.fluxField = "base_CompensatedTophatFlux_35_instFlux"
-config.normalizedCalibrationFlux.measure_ap_corr.sourceSelector["science"].signalToNoise.errField = "base_CompensatedTophatFlux_35_instFluxErr"
+config.normalizedCalibrationFlux.measure_ap_corr.sourceSelector[
+    "science"
+].signalToNoise.fluxField = "base_CompensatedTophatFlux_35_instFlux"
+config.normalizedCalibrationFlux.measure_ap_corr.sourceSelector[
+    "science"
+].signalToNoise.errField = "base_CompensatedTophatFlux_35_instFluxErr"
 config.measurement.slots.apFlux = "base_CircularApertureFlux_35_0"
 config.measurement.slots.calibFlux = "base_CircularApertureFlux_35_0"

config/latiss/coaddBase.py

@@ -25,4 +25,3 @@
 # These configs are for skymaps of pixel scale 0.1
 # TO DO: Delete the below if we go a 0.2 pixel scale.
 config.matchingKernelSize = 43
-

config/latiss/compareWarpAssembleCoadd.py

@@ -24,4 +24,3 @@
 
 # Load configs from base assembleCoadd
 config.load(os.path.join(os.path.dirname(__file__), "assembleCoadd.py"))
-

config/latiss/fgcmBuildFromIsolatedStars.py

@@ -10,15 +10,15 @@
 config.minPerBand = 2
 config.connections.ref_cat = "atlas_refcat2_20220201"
 
-config.apertureInnerInstFluxField="apFlux_35_0_instFlux"
-config.apertureOuterInstFluxField="apFlux_50_0_instFlux"
+config.apertureInnerInstFluxField = "apFlux_35_0_instFlux"
+config.apertureOuterInstFluxField = "apFlux_50_0_instFlux"
 
 configDir = os.path.join(os.path.dirname(__file__))
 config.physicalFilterMap = LATISS_FILTER_DEFINITIONS.physical_to_band
 config.doSubtractLocalBackground = False
 config.fgcmLoadReferenceCatalog.load(os.path.join(configDir, "filterMap.py"))
 config.fgcmLoadReferenceCatalog.applyColorTerms = True
-config.fgcmLoadReferenceCatalog.colorterms.load(os.path.join(configDir, 'colorterms.py'))
+config.fgcmLoadReferenceCatalog.colorterms.load(os.path.join(configDir, "colorterms.py"))
 config.fgcmLoadReferenceCatalog.referenceSelector.doSignalToNoise = True
 config.fgcmLoadReferenceCatalog.referenceSelector.signalToNoise.fluxField = "i_flux"
 config.fgcmLoadReferenceCatalog.referenceSelector.signalToNoise.errField = "i_fluxErr"

config/latiss/fgcmFitCycle.py

@@ -29,7 +29,7 @@
 config.maxIterBeforeFinalCycle = 100
 config.minCcdPerExp = 1
 config.utBoundary = 0.0
-config.washMjds = (0.0, )
+config.washMjds = (0.0,)
 # For now, define 1 observing epoch that encompasses everything.
 config.epochMjds = (0.0, 100000.0)
 config.coatingMjds = []

config/latiss/fgcmMakeLut.py

@@ -19,4 +19,4 @@
                                        "empty~SDSSy_65mm": "SDSSy_65mm~empty"}
 
 # FGCM name or filename of precomputed atmospheres
-config.atmosphereTableName = 'fgcm_atm_lsst2'
+config.atmosphereTableName = "fgcm_atm_lsst2"

config/latiss/fgcmOutputProducts.py

@@ -1,4 +1,5 @@
+from lsst.obs.lsst.filters import LATISS_FILTER_DEFINITIONS
+
 config.connections.cycleNumber = 6
 
-from lsst.obs.lsst.filters import LATISS_FILTER_DEFINITIONS
 config.physicalFilterMap = LATISS_FILTER_DEFINITIONS.physical_to_band