Skip to content

Commit

Permalink
Merge branch 'tickets/DM-37952'
Browse files Browse the repository at this point in the history
  • Loading branch information
laurenam committed Jun 3, 2024
2 parents 697cf85 + 727f1bb commit c0f17ef
Show file tree
Hide file tree
Showing 3 changed files with 50 additions and 6 deletions.
33 changes: 33 additions & 0 deletions config/comCamSim/makeWarp.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
# This file is part of obs_lsst.
#
# Developed for the LSST Data Management System.
# This product includes software developed by the LSST Project
# (http://www.lsst.org).
# See the COPYRIGHT file at the top-level directory of this distribution
# for details of code ownership.
#
# This program is free software: you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation, either version 3 of the License, or
# (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the LSST License Statement and
# the GNU General Public License along with this program. If not,
# see <http://www.lsstcorp.org/LegalNotices/>.

"""LSSTComCamSim-specific overrides for MakeWarpTask"""

# These thresholds can be tightened for the simulated data compared to the
# task defaults (which were conditioned on HSC data). These have been
# chosen based on the OR3 dataset reduced with w_2024_19 pipeline on
# DM-37952 (see ticket for figures).
config.select.maxEllipResidual = 0.0026
config.select.maxScaledSizeScatter = 0.014
config.select.maxPsfTraceRadiusDelta = 0.065
config.select.maxPsfApFluxDelta = 0.047
config.select.maxPsfApCorrSigmaScaledDelta = 0.041
5 changes: 4 additions & 1 deletion config/imsim/makeWarp.py
Original file line number Diff line number Diff line change
Expand Up @@ -34,5 +34,8 @@
# The maxScaledSizeScatter has been increased further to reflect the new
# metric definition (which results in higher values for this metric). See
# DM-40668 & DM-41838 for details.
config.select.maxEllipResidual = 0.005
config.select.maxEllipResidual = 0.0036
config.select.maxScaledSizeScatter = 0.011
config.select.maxPsfTraceRadiusDelta = 0.09
config.select.maxPsfApFluxDelta = 0.062
config.select.maxPsfApCorrSigmaScaledDelta = 0.053
18 changes: 13 additions & 5 deletions config/latiss/makeWarp.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,19 @@
# defaults (which were conditioned on HSC data). These have been chosen
# based on the data observed in the 2022-11B (PREOPS-1986) and 2022-12A
# (PREOPS-3135) runs (see figures on DM-37497) and are probably going to
# evolve as the commissioning of AuxTel procedes.
config.select.maxEllipResidual = 0.1
# Updated with DM-40668
config.select.maxScaledSizeScatter = 0.025
config.select.maxPsfTraceRadiusDelta = 4.8
# evolve as the commissioning of AuxTel proceeds. Further updated for
# DM-40668....and the latest update is based on a reassessment as part of
# the addition of two additional metrics on DM-37952 using the data
# satisfying:
# (exposure.day_obs>=20230509 AND exposure.day_obs<=20240513) AND
# (exposure.observation_type='science') AND
# (exposure.science_program='AUXTEL_PHOTO_IMAGING' OR
# exposure.science_program='AUXTEL_DRP_IMAGING')"
config.select.maxEllipResidual = 0.027
config.select.maxScaledSizeScatter = 0.026
config.select.maxPsfTraceRadiusDelta = 2.9
config.select.maxPsfApFluxDelta = 0.075
config.select.maxPsfApCorrSigmaScaledDelta = 0.118

# PSF-matching configs are in units of pix and specific to skymap pixel scale

Expand Down

0 comments on commit c0f17ef

Please sign in to comment.