DM-39999: Add UC Davis Beam simulator ITL camera #462
Conversation
timj
changed the title
Snyder005
force-pushed
the
tickets/DM-39999
branch
from
0fa2df0
to
3966986
Compare
Snyder005
force-pushed
the
tickets/DM-39999
branch
from
4218d2b
to
4d2ed9f
Compare
Snyder005
force-pushed
the
tickets/DM-39999
branch
from
6795d2d
to
e608ce2
Compare
There was a problem hiding this comment.
The Jira ticket does not make it clear but this PR is going to result in the older data not being importable into gen3 butlers. Is everyone okay with that? Today the "SAO" test stand data can be ingested but next week it won't be. As an archivist this seems wrong to me but if people are deleting all that data then that's going to be okay.
We can't merge this PR without some test headers being added to ensure that these files can be translated properly.
Snyder005
force-pushed
the
tickets/DM-39999
branch
from
2f1ff21
to
24308a5
Compare
|
Added test headers and wrote the test translator function for the new LSST-UCDCam camera definition. |
|
Can you confirm that the old data that this code worked with before will never needed to be looked at again? I'm yet to get a formal statement that those data are now irrelevant and nothing will need to look at them. |
|
Yes, the old data was only used by a few of us here at Davis and was never made available at USDF. We don't intend to use it within the DM Butler framework again. |
| instrume = header["INSTRUME"].lower() | ||
| if instrume == cls.supported_instrument.lower(): | ||
| return True | ||
| elif instrume == "LSST-UCDCam-ITL".lower(): |
There was a problem hiding this comment.
If ever we learn that this is a hotspot we could replace the string with "lsst-ucdcam-itl"...
Add UC Davis Beam Simulator ITL Camera to obs_lsst.