DM-39858: Add imSim-specific overrides for CalibrateImageTask #465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kfindeisen
approved these changes
Aug 16, 2023
| @@ -22,5 +22,4 @@ | |||
| """ | |||
| imsim-specific overrides for IsrTask | |||
| """ | |||
| config.doCrosstalk = True | |||
There was a problem hiding this comment.
If the obs_lsst default changed to False, would you want this one to follow suit or remain at True?
There was a problem hiding this comment.
Good question: I could see it going either way, but we know we need to do crosstalk correction in all the LSSTCam chips (simulated and real), so I don't foresee it ever being set to False in the lowest-level instrument override.
doCrosstalk is overridden to True in the base-level obs_lsst isr.py.
This is the value used in DRP and AP for all imsim datasets.
parejkoj
force-pushed
the
tickets/DM-39858
branch
from
1de619d
to
c5640ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.