DM-40301: Update configurations to use large 35 pixel aperture for LATISS calibration. #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurenam
approved these changes
Aug 16, 2023
config/latiss/calibrate.py
Outdated
| @@ -42,3 +42,7 @@ | |||
| config.doWriteMatchesDenormalized = True | |||
|
|
|||
| config.measurement.plugins["base_Jacobian"].pixelScale = 0.1 | |||
|
|
|||
| # Set the default aperture as appropriate for the LATISS platescale. | |||
There was a problem hiding this comment.
Huh...I always think of "plate scale" as two words (here and elsewhere in this PR if you decided to change it, but I'm not insisting!)
| 'y', | ||
| 'apFlux_50_0_instFlux', | ||
| 'apFlux_50_0_instFluxErr', | ||
| 'apFlux_50_0_flag', |
There was a problem hiding this comment.
For testing background offsets, fgcm uses the calibration aperture plus 1 larger. 50 is that one larger. (And the calibration flux already gets transferred, this is just the "extra" bit.)
The default 12 pixel aperture is much too small for the LATISS platescale.
erykoff
force-pushed
the
tickets/DM-40301
branch
from
08663c3
to
12f0864
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default 12 pixel aperture is much too small for the LATISS platescale.