Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-40955: LATISS psf stamp size is incorrect for the large PSFs #480

Merged
merged 1 commit into from
Nov 1, 2023
Merged

DM-40955: LATISS psf stamp size is incorrect for the large PSFs #480

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions config/latiss/characterizeImage.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@

# Reduce psfex spatialOrder to 1, this helps ensure success with low numbers of psf candidates.
config.measurePsf.psfDeterminer["psfex"].spatialOrder = 1
# Set the default kernel and stamp sizes for PSF modeling appropriate for LATISS
config.measurePsf.makePsfCandidates.kernelSize = 71
config.measurePsf.psfDeterminer["psfex"].stampSize = 71

config.installSimplePsf.width = 21
config.installSimplePsf.fwhm = 2.355*2 # LATISS plate scale is 2x LSST nominal
Expand Down
12 changes: 10 additions & 2 deletions config/latiss/finalize_characterization.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,10 @@
# Reduce piff spatialOrder to 1, this helps ensure success with low numbers of psf candidates.
config.psf_determiner['piff'].spatialOrder = 1
# Change the PSF determiner to psfex from piff default as the latter will not
# scale well to the large kernel/stamp sizes for PSF modeling for LATISS data.
import lsst.meas.extensions.psfex.psfexPsfDeterminer

config.psf_determiner.name = "psfex"
# Reduce spatialOrder to 1, this helps ensure success with low numbers of psf candidates.
config.psf_determiner["psfex"].spatialOrder = 1
# Set the default kernel and stamp sizes for PSF modeling appropriate for LATISS.
config.psf_determiner["psfex"].stampSize = 71
config.make_psf_candidates.kernelSize = 71
1 change: 1 addition & 0 deletions ups/obs_lsst.table
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ setupRequired(astro_metadata_translator)
setupRequired(obs_lsst_data)
setupRequired(daf_butler)
setupOptional(meas_extensions_gaap)
setupOptional(meas_extensions_psfex)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm never sure what should be optional or required here, and I'm sure this has to be picked up by pipe_tasks currently, but I think it's okay to have this here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not totally clear on this either! My reasoning was:
a) we should not rely on it being picked up by another required package (as that could change from underneath us).
b) it's "optional" because it is only actually "required" if processing LATISS data (but I'm not 100% sure that's correct reasoning since it seems that it's crossing a line).

I'll leave it as is for now (but will keep it in mind if we see problems down the road that could be related).


envPrepend(PYTHONPATH, ${PRODUCT_DIR}/python)
envPrepend(PATH, ${PRODUCT_DIR}/bin)
Expand Down