DM-42287: Simulated ComCam instrument model for ops-rehearsal-3 #498
Conversation
| See `~astro_metadata_translator.fix_header` for details of the general | ||
| process. | ||
| """ | ||
| modified = False |
There was a problem hiding this comment.
Could fix that TELESCOP problem described above.
tests/test_packer.py
Outdated
| day_obs=20240321, | ||
| seq_num=720, | ||
| detector=4, | ||
| controller="P" |
There was a problem hiding this comment.
I am concerned that we are using P controller to mean something other than what we have historically thought of as PLAYBACK. @ktlim and I discussed this and thought that it should be controller "S" for simulated. "P" is meant to mean rerun real observations exactly as they were taking on the mountain but maybe I'm misunderstanding.
There was a problem hiding this comment.
I'm not sure why I settled on "P" for the controller. This was something that carried over from a much earlier attempt to make a simulated LSSTCam. Reading the comments for the controller in translators/lsst.py, I agree that it makes more sense to use "S" for simulated. I'll make that change.
replace nan value for gain with average value from other amps on the same side of the chip
jchiang87
force-pushed
the
tickets/DM-42287
branch
from
613d15d
to
27a863b
Compare
jchiang87
force-pushed
the
tickets/DM-42287
branch
from
27a863b
to
7bec00d
Compare
No description provided.