DM-43143: Set mag limits for refcat loading in LSSTComCamSim #511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you're not going to make them the Task defaults for AstrometryTask and PhotoCalTask, please at least add them to the |
laurenam
force-pushed
the
tickets/DM-43143
branch
2 times, most recently
from
95a0bd7
to
a6ae7ab
Compare
parejkoj
reviewed
Mar 7, 2024
laurenam
force-pushed
the
tickets/DM-43143
branch
from
a6ae7ab
to
5da79f5
Compare
These have been selected to more than span the expected magnitude range for the icSrc catalog sources (those available for the calibrations). Loading in reference sources outside of this range is undesirable for a few reasons, including wasting time on objects that are not acutally in contention for matcing and, more importantly, leaving a danger of the fit getting "lost" by locking onto the "superfluous" reference catalog objects (we saw this happen in photoCal for 3 of 25935 dataIds in the first round Ops Rehearsal 3 dataset).
laurenam
force-pushed
the
tickets/DM-43143
branch
from
5da79f5
to
eec7390
Compare
parejkoj
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.