DM-45378: Add script that can be run to average lsstcam ITL crosstalks. #545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erykoff
force-pushed
the
tickets/DM-45378
branch
from
b43c64c
to
34518c5
Compare
czwa
reviewed
Jul 30, 2024
python/lsst/obs/lsst/script/write_comcam_estimated_non_linear_crosstalk_coeffs.py
Show resolved
Hide resolved
czwa
approved these changes
Jul 30, 2024
erykoff
force-pushed
the
tickets/DM-45378
branch
from
34518c5
to
80112be
Compare
timj
reviewed
Jul 30, 2024
| comcam_crosstalk.coeffValid = np.ones((n_amp, n_amp), dtype=np.bool_) | ||
| comcam_crosstalk.hasCrosstalk = True | ||
|
|
||
| out_path = os.path.join(data_root, "comCam", "crosstalk", name.lower()) |
There was a problem hiding this comment.
In theory if you have the instrument class you can do
Suggested change
| out_path = os.path.join(data_root, "comCam", "crosstalk", name.lower()) | |
| out_path = os.path.join(instr.getObsDataPackageDir(), instr.policyName, "crosstalk", name.lower()) |
and guarantee consistency with what the instrument class is going to do in write-curated-calibs (which is the wrong name and should have been ingest-curated-calibs). There is a private method in lsst.obs.base.Instrument that could be public
erykoff
force-pushed
the
tickets/DM-45378
branch
from
80112be
to
b92ea25
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.