DM-22302: Prefer -BEG headers over -OBS headers for datetime_begin #547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timj
changed the title
czwa
reviewed
Jul 31, 2024
| date_key = "MJD-BEG" | ||
| date_fmt = "mjd" | ||
| for k in ("MJD-BEG", "DATE-BEG", "MJD-OBS", "DATE-OBS"): | ||
| if self.is_key_ok(k): |
There was a problem hiding this comment.
I'm not sure I understand how this interacts with the default values. If none of these keys exist, it will still try to use MJD-BEG in the return value. Won't that cause a KeyError on L543?
There was a problem hiding this comment.
Yes. Which will fail the translation. The translation has to blow up anyhow if there aren't any keys available. I was mostly saving myself the trouble of writing my own exception message.
czwa
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.