Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-46188: changes to get LSST pipelines passing smoke tests in drp_pipe #568

Merged
merged 3 commits into from
Oct 25, 2024

Conversation

TallJimbo
Copy link
Member

No description provided.

The suffix on this override was incorrect (_photoMatch instead of
_match_photom), and just dropping the override seems to fix it,
presumably because of some magic in analysis_tools.
- Set the obs-package default for photometry to the_monster, override
  in ImSim, ComCamSim, and (for now?) LATISS.
- Don't include a comment that just repeats the file name.
- Don't set 'connections.data'; it's defined by a template that
  includes 'connections.refCatalog'.
@TallJimbo TallJimbo marked this pull request as ready for review October 24, 2024 18:59
Copy link
Contributor

@erykoff erykoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We changed LATISS to the monster from ATLAS recently.

@TallJimbo
Copy link
Member Author

We changed LATISS to the monster from ATLAS recently.

@mfisherlevine seems to have done that and then undone that for photometry on the very latest commit on main (as of this writing):

e3e606b#diff-8fbcd878082ed6a16f8d187f42ff8e31e44a015dbfa7cfb4b047d8713101876dL12

@erykoff
Copy link
Contributor

erykoff commented Oct 24, 2024

What?

Copy link
Contributor

@erykoff erykoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that https://github.com/lsst/obs_lsst/blob/main/config/calibrate.py astrometry refcat should be updated as well to use the monster for astrometry.

@TallJimbo
Copy link
Member Author

I started on this but it ballooned out of control, and I think I need to limit the scope of this ticket to the minimum needed to get the tests running with the pipelines configured more or less as they were. I've saved my progress on branches of DM-46454 and I will return to that work tomorrow, on that ticket or a new one.

Copy link
Contributor

@erykoff erykoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the monster needs to be set as the astrometry refcat in calibrate.py

@TallJimbo TallJimbo merged commit a3f7bb9 into main Oct 25, 2024
3 checks passed
@TallJimbo TallJimbo deleted the tickets/DM-46188 branch October 25, 2024 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants