-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DM-46188: changes to get LSST pipelines passing smoke tests in drp_pipe #568
Conversation
The suffix on this override was incorrect (_photoMatch instead of _match_photom), and just dropping the override seems to fix it, presumably because of some magic in analysis_tools.
- Set the obs-package default for photometry to the_monster, override in ImSim, ComCamSim, and (for now?) LATISS. - Don't include a comment that just repeats the file name. - Don't set 'connections.data'; it's defined by a template that includes 'connections.refCatalog'.
b90f4a7
to
fbcf8eb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We changed LATISS to the monster from ATLAS recently.
@mfisherlevine seems to have done that and then undone that for photometry on the very latest commit on e3e606b#diff-8fbcd878082ed6a16f8d187f42ff8e31e44a015dbfa7cfb4b047d8713101876dL12 |
What? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that https://github.com/lsst/obs_lsst/blob/main/config/calibrate.py astrometry refcat should be updated as well to use the monster for astrometry.
I started on this but it ballooned out of control, and I think I need to limit the scope of this ticket to the minimum needed to get the tests running with the pipelines configured more or less as they were. I've saved my progress on branches of DM-46454 and I will return to that work tomorrow, on that ticket or a new one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the monster needs to be set as the astrometry refcat in calibrate.py
No description provided.