Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-42221: Pushed the Replication/Ingest system's classes into the dedicated subfolders #825

Merged
merged 2 commits into from
Dec 21, 2023

Conversation

iagaponenko
Copy link
Contributor

…folders

The classes are now clustered within subfolders based on class's role and functionality. CMake files were added to the relevant subfolders. Include headers were rearranged in alphabetical order.

…folders

The classes are now clustered within subfolders based on class's role
and functionality. CMake files were added to the relevant subfolders.
Include headers were rearranged in alphabetical order.
The change was needed to allow virtual sub-libraries of the module
'replica' to be compiled after the protobuf headers are already available.
An explicit dependency onto the virtual protobuf library was added
in the relevant CMake files of the dependent virtual libraries.
Copy link
Contributor

@fritzm fritzm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iagaponenko iagaponenko merged commit a166c1e into main Dec 21, 2023
15 checks passed
@iagaponenko iagaponenko deleted the tickets/DM-42221 branch December 21, 2023 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants