-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DM-46919: Extend the http frontend of Qserv to support pushing CSV files in the multipart/form-data body #876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iagaponenko
force-pushed
the
tickets/DM-46919
branch
6 times, most recently
from
November 9, 2024 05:57
ba72521
to
f8b0c67
Compare
jgates108
approved these changes
Nov 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just minor comments.
…tted requests The new version of the class allows sending file attachments in the streaming mode, along with parts.
iagaponenko
force-pushed
the
tickets/DM-46919
branch
from
November 15, 2024 03:08
f8b0c67
to
4b08a3b
Compare
The rafactoring prepares ground for introducing another implementation of the REST API for ingesting tables in the "multi-part/form" body. The new intermediate base class will prevent code duplication after adding the second module.
Refactored the command line application qserv-czar-http to use Boost options for command line parsing. Extended the integration test scripts and the configuration file accordingly.
iagaponenko
force-pushed
the
tickets/DM-46919
branch
from
November 15, 2024 19:12
4b08a3b
to
0d6e30c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.