Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for compression level in ZstdDictTrainer #347

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

tomerr90
Copy link
Contributor

@tomerr90 tomerr90 commented Jan 24, 2025

@luben Sorry, not sure if I should have added you as a reviewer somehow

@luben
Copy link
Owner

luben commented Jan 27, 2025

LGTM, running the tests

Copy link

codecov bot commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.90%. Comparing base (c76455c) to head (75f1fc2).
Report is 36 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #347      +/-   ##
============================================
- Coverage     60.01%   59.90%   -0.11%     
- Complexity      308      313       +5     
============================================
  Files            26       27       +1     
  Lines          1473     1524      +51     
  Branches        170      177       +7     
============================================
+ Hits            884      913      +29     
- Misses          434      451      +17     
- Partials        155      160       +5     

@luben luben merged commit adb1ea2 into luben:master Jan 27, 2025
7 of 8 checks passed
@tomerr90 tomerr90 deleted the patch-1 branch January 27, 2025 13:58
@tomerr90
Copy link
Contributor Author

tomerr90 commented Feb 2, 2025

Thanks @luben !
When are you planning on publishing a new version?

@luben
Copy link
Owner

luben commented Feb 4, 2025

Yes, I will publish it later this week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants