Bug in RemoveAt function #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…edit existing values so far, no add/remove keys or sorting stuff
…ictionary was modified while enumerating over it
…ryEntry values rather than KeyValuePairs - same approach as is taken in Mono's Dictionary class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, just wanted to comment that I ran into a bug with the removeAt function.
If you have a dictionary with 2 entries, and you remove the 2nd one, removeAt will not correctly remove it from the _cache. It removes it at the start of the function, but re adds it in the if(_keys.Count > 1) block.
I fixed the problem by adding "&& index != _keys.Count-1" to the if statement
( I should mention that after this happened, TryGetValue would return an error when trying to get the removed value, which caused me quite a few problems)