refactor(nx-python): fix sonarcloud code smell

lucasvieirasilva · Nov 10, 2023 · 5c03227 · 5c03227
1 parent df53e89
commit 5c03227
Showing 1 changed file with 27 additions and 14 deletions.
diff --git a/packages/nx-python/src/generators/poetry-project/generator.ts b/packages/nx-python/src/generators/poetry-project/generator.ts
@@ -34,20 +34,10 @@ function normalizeOptions(
   tree: Tree,
   options: PoetryProjectGeneratorSchema
 ): NormalizedSchema {
-  let projectName = options.name;
-  let projectRoot = options.directory || options.name;
-  if (options.projectNameAndRootFormat === 'derived') {
-    const name = names(options.name).fileName;
-    const projectDirectory = options.directory
-      ? `${names(options.directory).fileName}/${name}`
-      : name;
-    projectName = projectDirectory.replace(/\//g, '-');
-    projectRoot = `${
-      options.projectType === 'application'
-        ? getWorkspaceLayout(tree).appsDir
-        : getWorkspaceLayout(tree).libsDir
-    }/${projectDirectory}`;
-  }
+  const { projectName, projectRoot } = calculateProjectNameAndRoot(
+    options,
+    tree
+  );
 
   const parsedTags = options.tags
     ? options.tags.split(',').map((s) => s.trim())
@@ -118,6 +108,29 @@ function normalizeOptions(
   };
 }
 
+function calculateProjectNameAndRoot(
+  options: PoetryProjectGeneratorSchema,
+  tree: Tree
+) {
+  let projectName = options.name;
+  let projectRoot = options.directory || options.name;
+
+  if (options.projectNameAndRootFormat === 'derived') {
+    const name = names(options.name).fileName;
+    const projectDirectory = options.directory
+      ? `${names(options.directory).fileName}/${name}`
+      : name;
+    projectName = projectDirectory.replace(/\//g, '-');
+    projectRoot = `${
+      options.projectType === 'application'
+        ? getWorkspaceLayout(tree).appsDir
+        : getWorkspaceLayout(tree).libsDir
+    }/${projectDirectory}`;
+  }
+
+  return { projectName, projectRoot };
+}
+
 function getPyTestAddopts(
   options: PoetryProjectGeneratorSchema,
   projectRoot: string