Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft implementation of NoiseClient #866

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

samhunt
Copy link

@samhunt samhunt commented Jul 1, 2023

Initial draft implementation of adding NoiseClient (Encryption) to the esphome-ts library.

This got all the way through the handshake, but then any subsequent messages would never get accepted by the server.

Unfortunately I ran into a few stumbling blocks with the actual implementation of esphome-ts mainly due to the inconsistent nature of how parseListResponse would frequently drop entities (or not all entities would be received) before ListEntitiesDoneResponse was received. Once ListEntitiesDoneResponse was acknowledged no further entities would be added to the list, and therefore were never able to be added to HomeBridge.
Due to this I instead switched out this implementation of the Esphome Native API esphome-native-api which already had encryption, and far more Entities implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant