-
-
Notifications
You must be signed in to change notification settings - Fork 661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added courier-package and customs-check icons #2747
base: main
Are you sure you want to change the base?
Conversation
Added or changed iconsIcons as codeWorks for: const CourierPackageIcon = createLucideIcon('CourierPackage', [
["path",{"d":"M13 17h3a2 2 0 0 1 0 4h-3a6 6 0 0 1-5.22-3"}],
["path",{"d":"M17.73 20H21a1 1 0 0 0 1-1v-6a1 1 0 0 0-1-1h-7a1 1 0 0 0-1 1v4a2 2 0 0 1-1.814-1.157l-1.514-3.207A3 3 0 0 0 7.17 11H6.002A3 3 0 0 0 3 14v7"}],
["path",{"d":"M2.027 6H14"}],
["circle",{"cx":"6.5","cy":"6.508","r":"4.508"}]
])
const CustomsControlIcon = createLucideIcon('CustomsControl', [
["path",{"d":"M12 20h9"}],
["path",{"d":"M12 22v-3a1 1 0 0 0-1-1H4a1 1 0 0 0-1 1"}],
["path",{"d":"M19.828 13.172 13 20"}],
["path",{"d":"M20 7H9"}],
["path",{"d":"M20 8a4 4 0 0 1-8 0V3.28a1 1 0 0 1 1.242-.97l6 1.5a1 1 0 0 1 .758.97z"}],
["path",{"d":"M21 22v-6a4 4 0 0 0-4-4h-2.752a4 4 0 0 0-3.115 1.49L6.5 18"}],
["path",{"d":"m5 12-1.795 5.384A4 4 0 0 0 3 18.65V22"}]
]) |
Fixed stroke issues in courier-package and customs-check icons. Updated to preserve strokes and align with Lucide's guidelines. |
Heya @karsa-mistmere, Thanks for the feedback and the Lucide Studio link (it's great!) Updated both customs-check and courier-package icons to address guideline issues. Ready for another review! 😊 Here's a little preview with other icons I plan to use on my project: |
Some remaining issues with the designs:
I'm also a bit unsure whether |
9px wide, but only 8px tall, it's the smaller one dimension matters.
I think the sash actually makes the uniform much more readily recognisable. |
Gotcha! Maybe the guidelines could be updated to say <= 8px 😁
Works for me! I'll make the necessary changes. Any thoughts about the name? Should we rename it to customs-officer? |
Updated the icons based on recommendations. Also renamed customs-check to customs-control. |
With parallel arms and rounded hat: |
The second one's supposed to be a sash, not an arm. 😅 |
Hehe. Now I can't unsee the 2nd arm. @jguddas looks good! I pushed these small tweaks. 👍 |
I've made all requested changes and updated the branch. Let me know if there's anything else I should adjust. 😊 |
Co-authored-by: Jakob Guddas <[email protected]>
Co-authored-by: Jakob Guddas <[email protected]>
N/A
What is the purpose of this pull request?
Description
This pull request adds two new icons:
courier-package
: Represents delivery or courier services.customs-check
: Represents customs inspections or border checks.Icon use case
courier-package
:customs-check
:Alternative icon designs
N/A – these designs were chosen based on simplicity and adherence to Lucide’s design principles.
Icon Design Checklist
Concept
Author, credits & license
Naming
icons/[iconName].json
.Design
Before Submitting