Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added courier-package and customs-check icons #2747

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

irvineacosta
Copy link

N/A

What is the purpose of this pull request?

  • New Icon
  • Bug fix
  • New Feature
  • Documentation update
  • Other:

Description

This pull request adds two new icons:

  • courier-package: Represents delivery or courier services.
  • customs-check: Represents customs inspections or border checks.

Icon use case

  • courier-package:
    • Used on e-commerce platforms for delivery-related actions, such as shipping notifications or order tracking.
    • Representing courier services or logistics in delivery-related applications.
  • customs-check:
    • Indicating customs inspection processes in travel-related or logistics applications.
    • Used in airport systems, border control apps, or any platform related to international trade and travel.

Alternative icon designs

N/A – these designs were chosen based on simplicity and adherence to Lucide’s design principles.

Icon Design Checklist

Concept

  • I have provided valid use cases for each icon.
  • I have not added any brand or logo icon.
  • I have not used any hate symbols.
  • I have not included any religious or political imagery.

Author, credits & license

  • The icons are solely my own creation.
  • The icons were originally created in # by @
  • I've based them on the following Lucide icons:
  • I've based them on the following design:

Naming

  • I've read and followed the naming conventions.
  • I've named icons by what they are rather than their use case.
  • I've provided meta JSON files in icons/[iconName].json.

Design

  • I've read and followed the icon design guidelines.
  • I've made sure that the icons look sharp on low DPI displays.
  • I've made sure that the icons look consistent with the icon set in size, optical volume, and density.
  • I've made sure that the icons are visually centered.
  • I've correctly optimized all icons to three points of precision.

Before Submitting

@github-actions github-actions bot added 🎨 icon About new icons 🫧 metadata Improved metadata labels Jan 22, 2025
Copy link

github-actions bot commented Jan 22, 2025

Added or changed icons

icons/courier-package.svgicons/customs-control.svg

Preview cohesion icons/square-chevron-up.svgicons/square-arrow-out-down-left.svg
icons/courier-package.svgicons/customs-control.svg
icons/square-check-big.svgicons/layout-dashboard.svg
Preview stroke widths icons/courier-package.svgicons/customs-control.svg
icons/courier-package.svgicons/customs-control.svg
icons/courier-package.svgicons/customs-control.svg
DPI Preview (24px) icons/courier-package.svg icons/customs-control.svg
Icon X-rays icons/courier-package.svg icons/customs-control.svg
Icon Diffs icons/courier-package.svg icons/customs-control.svg
Icons as code

Works for: lucide-react, lucide-react-native, lucide-preact, lucide-vue-next

const CourierPackageIcon = createLucideIcon('CourierPackage', [
  ["path",{"d":"M13 17h3a2 2 0 0 1 0 4h-3a6 6 0 0 1-5.22-3"}],
  ["path",{"d":"M17.73 20H21a1 1 0 0 0 1-1v-6a1 1 0 0 0-1-1h-7a1 1 0 0 0-1 1v4a2 2 0 0 1-1.814-1.157l-1.514-3.207A3 3 0 0 0 7.17 11H6.002A3 3 0 0 0 3 14v7"}],
  ["path",{"d":"M2.027 6H14"}],
  ["circle",{"cx":"6.5","cy":"6.508","r":"4.508"}]
])

const CustomsControlIcon = createLucideIcon('CustomsControl', [
  ["path",{"d":"M12 20h9"}],
  ["path",{"d":"M12 22v-3a1 1 0 0 0-1-1H4a1 1 0 0 0-1 1"}],
  ["path",{"d":"M19.828 13.172 13 20"}],
  ["path",{"d":"M20 7H9"}],
  ["path",{"d":"M20 8a4 4 0 0 1-8 0V3.28a1 1 0 0 1 1.242-.97l6 1.5a1 1 0 0 1 .758.97z"}],
  ["path",{"d":"M21 22v-6a4 4 0 0 0-4-4h-2.752a4 4 0 0 0-3.115 1.49L6.5 18"}],
  ["path",{"d":"m5 12-1.795 5.384A4 4 0 0 0 3 18.65V22"}]
])

@irvineacosta
Copy link
Author

Fixed stroke issues in courier-package and customs-check icons. Updated to preserve strokes and align with Lucide's guidelines.

@irvineacosta
Copy link
Author

Heya @karsa-mistmere,

Thanks for the feedback and the Lucide Studio link (it's great!)

Updated both customs-check and courier-package icons to address guideline issues. Ready for another review! 😊

Here's a little preview with other icons I plan to use on my project:
image

@karsa-mistmere
Copy link
Member

Some remaining issues with the designs:

  • The boxes are ≤8px, so a 1px rounding is adequate
  • The police hat does not have the necessary 2px gap within it (you should be able to fit a circle of 2px diameter within it, with no overlap), the icon itself is not horizontally centred either.

I'm also a bit unsure whether customs-check is legible enough, both the open luggage and the police hat feel "wrong" enough that I'm not sure I could tell it's not some random clerk or cashier in a cap were I now already in the know. 🤔

@irvineacosta
Copy link
Author

Hi @karsa-mistmere

Thank you for the quick reply.

The boxes are 9px wide. Do we only count the inside pixels?

As for customs-check, perhaps renaming it to customs-officer would make more sense because of the uniform?

This is the inspiration for it:
image

I also tried the sash but i think the tie looks better (simpler too). I'd love to hear your thoughts.

image

(I already updated these with adequate space inside the hat, as well as 1px rounding instead of 2).

@karsa-mistmere
Copy link
Member

The boxes are 9px wide. Do we only count the inside pixels?

9px wide, but only 8px tall, it's the smaller one dimension matters.

I also tried the sash but i think the tie looks better (simpler too). I'd love to hear your thoughts.

I think the sash actually makes the uniform much more readily recognisable.

@irvineacosta
Copy link
Author

9px wide, but only 8px tall, it's the smaller one dimension matters.

Gotcha! Maybe the guidelines could be updated to say <= 8px 😁

I think the sash actually makes the uniform much more readily recognisable.

Works for me! I'll make the necessary changes. Any thoughts about the name? Should we rename it to customs-officer?

@irvineacosta
Copy link
Author

Updated the icons based on recommendations. Also renamed customs-check to customs-control.

@jguddas
Copy link
Member

jguddas commented Jan 23, 2025

With parallel arms and rounded hat:
icons
Open lucide studio

@karsa-mistmere
Copy link
Member

With parallel arms and rounded hat: iconsOpen lucide studio

The second one's supposed to be a sash, not an arm. 😅

@irvineacosta
Copy link
Author

Hehe. Now I can't unsee the 2nd arm.

@jguddas looks good! I pushed these small tweaks. 👍

@jguddas
Copy link
Member

jguddas commented Jan 23, 2025

icons
Open lucide studio

@irvineacosta
Copy link
Author

I've made all requested changes and updated the branch. Let me know if there's anything else I should adjust. 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 icon About new icons 🫧 metadata Improved metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants