Optimize token filter and qparser for a 4x increase in throughput #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing to a 4x increase in throughput. The QParser also reduces data copying by creating the phrase map once in inform() instead of every time the qparser is invoked.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request optimizes the token filter and qparser for a 4x increase in throughput mostly by cutting down copies of data as well as CPU spent during said copy operations. Most places that used cha[] earlier now use String. Even though it looks like it should be more inefficient now, the master code had to create strings out of those char[] in many places which was slower and wasteful. Similarly, I use LinkedList instead of ArrayList for unusedTokens so that the removeFirst operation is O(1).
This PR also adds a .gitignore file.