Fix NPE on Sponge from null sender unique id (#481)

lucko · Feb 23, 2025 · d885e27 · d885e27
1 parent 509aa7a
commit d885e27
Showing 1 changed file with 6 additions and 10 deletions.
diff --git a/spark-sponge/src/main/java/me/lucko/spark/sponge/SpongeCommandSender.java b/spark-sponge/src/main/java/me/lucko/spark/sponge/SpongeCommandSender.java
@@ -83,15 +83,11 @@ public boolean hasPermission(String permission) {
     }
 
     @Override
-    public boolean equals(Object o) {
-        if (this == o) return true;
-        if (o == null || getClass() != o.getClass()) return false;
-        SpongeCommandSender that = (SpongeCommandSender) o;
-        return this.getUniqueId().equals(that.getUniqueId());
-    }
-
-    @Override
-    public int hashCode() {
-        return getUniqueId().hashCode();
+    protected Object getObjectForComparison() {
+        UUID uniqueId = getUniqueId();
+        if (uniqueId != null) {
+            return uniqueId;
+        }
+        return getName();
     }
 }