feat: fix item finding story error when focusing (#403)

lukasbach · Aug 5, 2024 · 58e3ed9 · 58e3ed9
1 parent ee68324
commit 58e3ed9
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 10 deletions.
diff --git a/packages/core/src/stories/FindingItems.stories.tsx b/packages/core/src/stories/FindingItems.stories.tsx
@@ -11,7 +11,7 @@ export default {
 } as Meta;
 
 export const CustomFinder = () => {
-  const [search, setSearch] = useState('');
+  const [search, setSearch] = useState('pizza');
   const tree = useRef<TreeRef>(null);
 
   const dataProvider = useMemo(
@@ -47,12 +47,11 @@ export const CustomFinder = () => {
       if (search) {
         findItemPath(search).then(path => {
           if (path) {
-            tree.current
-              ?.expandSubsequently(path.slice(0, path.length - 1))
-              .then(() => {
-                tree.current?.selectItems([path[path.length - 1]]);
-                tree.current?.focusItem(path[path.length - 1]);
-              });
+            // wait for full path including leaf, to make sure it loaded in
+            tree.current?.expandSubsequently(path).then(() => {
+              tree.current?.selectItems([path[path.length - 1]]);
+              tree.current?.focusItem(path[path.length - 1]);
+            });
           }
         });
       }

diff --git a/packages/docs/docs/guides/search.mdx b/packages/docs/docs/guides/search.mdx
@@ -157,9 +157,8 @@ function App() {
       if (search) {
         findItemPath(search).then(path => {
           if (path) {
-            tree.current
-              .expandSubsequently(path.slice(0, path.length - 1))
-              .then(() => {
+            // wait for full path including leaf, to make sure it loaded in
+            tree.current?.expandSubsequently(path).then(() => {
                 tree.current.selectItems([path[path.length - 1]]);
                 tree.current.focusItem(path[path.length - 1]);
               });