Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing SIGSEGV when no file is parsed #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixing SIGSEGV when no file is parsed #5

wants to merge 1 commit into from

Conversation

libesz
Copy link

@libesz libesz commented Mar 5, 2017

If I run go-outline without any option, it falls into a segmentation fault here.

$ go-outline
error: Could not parse file 
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x20 pc=0x4f04a3]
...

The fix is to os.Exit() after file parsing error is reported.

@aybabtme aybabtme mentioned this pull request Mar 9, 2017
Closed
@bzz
Copy link

bzz commented Apr 12, 2017 •
edited
Loading

Stumbled up on this confusing behavior as well. Is there a reason not to merge this or #6 , @lukehoban ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@libesz @bzz