Skip to content

Commit

Permalink
Fix some typos and clarify a couple of sentences (#128)
Browse files Browse the repository at this point in the history
  • Loading branch information
leo-bogastry authored Sep 8, 2023
1 parent 0a58fae commit 2f5f4fe
Show file tree
Hide file tree
Showing 41 changed files with 71 additions and 71 deletions.
12 changes: 6 additions & 6 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ need to be installed:
* The `cmtc` Course Management Tools Client CLI
* An IDE

The following sections detail how these components.
The following sections detail how to install these components.

### Install Coursier

Expand Down Expand Up @@ -122,7 +122,7 @@ Exercises in repository:
#### Verifying the course installation
Verify that the the course was installed correctly by launching `sbt test` in the root folder of the
Verify that the course was installed correctly by launching `sbt test` in the root folder of the
course exercises. You should see the following output:
```bash
Expand Down Expand Up @@ -199,7 +199,7 @@ As can be seen in the above output, `cmtc` installed the course in the `/Users/e
#### Verifying the course installation
Verify that the the course was installed correctly by launching `sbt test` in the root folder of the
Verify that the course was installed correctly by launching `sbt test` in the root folder of the
course exercises. You should see the following output:
```bash
Expand Down Expand Up @@ -228,13 +228,13 @@ org.lunatechlabs.dotty.sudoku.ReductionRuleSuite:
+ Applying reduction rules should eliminate values in isolated complete sets from occurrences in other cells (First reduction rule) 0.045s
+ Applying reduction rules should eliminate values in isolated complete sets of 5 values from occurrences in other cells (First reduction rule) 0.001s
+ Applying reduction rules should eliminate values in 2 isolated complete sets of 3 values from occurrences in other cells (First reduction rule) 0.001s
+ Applying reduction rules should eliminate values in shadowed complete sets from occurrences in same cells (Second reduction rule) 0.001s
+ Applying reduction rules should eliminate values in shadowed complete (6 value) sets from occurrences in same cells (Second reduction rule) 0.001s
+ Applying reduction rules should eliminate values in shadowed complete sets from occurrences in the same cells (Second reduction rule) 0.001s
+ Applying reduction rules should eliminate values in shadowed complete (6 value) sets from occurrences in the same cells (Second reduction rule) 0.001s
SLF4J: A number (1) of logging calls during the initialization phase have been intercepted and are
SLF4J: now being replayed. These are subject to the filtering rules of the underlying logging system.
SLF4J: See also http://www.slf4j.org/codes.html#replay
org.lunatechlabs.dotty.sudoku.SudokuDetailProcessorSuite:
+ Sending no updates to a sudoku detail processor should result in sending a SudokuDetailUnchanged messsage 0.007s
+ Sending no updates to a sudoku detail processor should result in sending a SudokuDetailUnchanged message 0.007s
+ Sending an update to a fresh instance of the SudokuDetailProcessor that sets one cell to a single value should result in sending an update that reflects this update 0.002s
+ Sending a series of subsequent Updates to a SudokuDetailProcessor should result in sending updates and ultimately return no changes 0.003s
[info] Passed: Total 11, Failed 0, Errors 0, Passed 11
Expand Down
6 changes: 3 additions & 3 deletions exercises/exercise_000_sudoku_solver_initial_state/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ SLF4J: now being replayed. These are subject to the filtering rules of the under
SLF4J: See also http://www.slf4j.org/codes.html#replay
[info] SudokuDetailProcessorSpec:
[info] Sending no updates to a sudoku detail processor
[info] - should result in sending a SudokuDetailUnchanged messsage
[info] - should result in sending a SudokuDetailUnchanged message
[info] Sending an update to a fresh instance of the SudokuDetailProcessor that sets one cell to a single value
[info] - should result in sending an update that reflects this update
[info] Sending a series of subsequent Updates to a SudokuDetailProcessor
Expand All @@ -65,8 +65,8 @@ SLF4J: See also http://www.slf4j.org/codes.html#replay
[info] - should Eliminate values in isolated complete sets from occurrences in other cells (First reduction rule)
[info] - should Eliminate values in isolated complete sets of 5 values from occurrences in other cells (First reduction rule)
[info] - should Eliminate values in 2 isolated complete sets of 3 values from occurrences in other cells (First reduction rule)
[info] - should Eliminate values in shadowed complete sets from occurrences in same cells (Second reduction rule)
[info] - should Eliminate values in shadowed complete (6 value) sets from occurrences in same cells (Second reduction rule)
[info] - should Eliminate values in shadowed complete sets from occurrences in the same cells (Second reduction rule)
[info] - should Eliminate values in shadowed complete (6 value) sets from occurrences in the same cells (Second reduction rule)
[info] CellMappingSpec:
[info] Mapping row coordinates
[info] - should result in correct column & block coordinates
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ class ReductionRuleSuite extends munit.FunSuite with SudokuTestHelpers {
}

test(
"Applying reduction rules should eliminate values in shadowed complete sets from occurrences in same cells (Second reduction rule)") {
"Applying reduction rules should eliminate values in shadowed complete sets from occurrences in the same cells (Second reduction rule)") {
val input = stringToReductionSet(
Vector(
"12 5 789", // (1,2,7,8) shadowed & complete
Expand Down Expand Up @@ -160,7 +160,7 @@ class ReductionRuleSuite extends munit.FunSuite with SudokuTestHelpers {
}

test(
"Applying reduction rules should eliminate values in shadowed complete (6 value) sets from occurrences in same cells (Second reduction rule)") {
"Applying reduction rules should eliminate values in shadowed complete (6 value) sets from occurrences in the same cells (Second reduction rule)") {
val input = stringToReductionSet(
Vector(
"123456 89", // (1,2,3,4,5,6) shadowed & complete
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ class SudokuDetailProcessorSuite extends munit.FunSuite with SudokuTestHelpers {
testKit.shutdownTestKit()
}

test("Sending no updates to a sudoku detail processor should result in sending a SudokuDetailUnchanged messsage") {
test("Sending no updates to a sudoku detail processor should result in sending a SudokuDetailUnchanged message") {

val probe = testKit.createTestProbe[SudokuDetailProcessor.Response]()
val detailProcessor = testKit.spawn(SudokuDetailProcessor[Row](id = 0))
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ where possible standard options include:
-source source version
```

We will add some code that trigger a number of compiler warnings which can
We will add some code that triggers a number of compiler warnings which can
be corrected by the compiler's code rewriting capabilities.

Add the following code snippet to the `src/main/scala/org/lunatechlabs/dotty/sudoku/SudokuSolver.scala` source code file:
Expand Down Expand Up @@ -147,7 +147,7 @@ wildcard import syntax from using an asterix (`*`) instead of an underscore (`_`
- Add the "-rewrite" option to have the compiler apply all the reported
changes.
- The end result should be that, after the compiler has applied its rewrites, the source code
compiles clean.
compiles successfully.
- Remove the `-rewrite` from `scalacOptions` in the sbt build definition.
- Checkpoint the current state of your code by commiting the changes to git:

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ class ReductionRuleSuite extends munit.FunSuite with SudokuTestHelpers {
}

test(
"Applying reduction rules should eliminate values in shadowed complete sets from occurrences in same cells (Second reduction rule)") {
"Applying reduction rules should eliminate values in shadowed complete sets from occurrences in the same cells (Second reduction rule)") {
val input = stringToReductionSet(
Vector(
"12 5 789", // (1,2,7,8) shadowed & complete
Expand Down Expand Up @@ -160,7 +160,7 @@ class ReductionRuleSuite extends munit.FunSuite with SudokuTestHelpers {
}

test(
"Applying reduction rules should eliminate values in shadowed complete (6 value) sets from occurrences in same cells (Second reduction rule)") {
"Applying reduction rules should eliminate values in shadowed complete (6 value) sets from occurrences in the same cells (Second reduction rule)") {
val input = stringToReductionSet(
Vector(
"123456 89", // (1,2,3,4,5,6) shadowed & complete
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ class SudokuDetailProcessorSuite extends munit.FunSuite with SudokuTestHelpers {
testKit.shutdownTestKit()
}

test("Sending no updates to a sudoku detail processor should result in sending a SudokuDetailUnchanged messsage") {
test("Sending no updates to a sudoku detail processor should result in sending a SudokuDetailUnchanged message") {

val probe = testKit.createTestProbe[SudokuDetailProcessor.Response]()
val detailProcessor = testKit.spawn(SudokuDetailProcessor[Row](id = 0))
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ Scala 3 introduces some new syntax which can be divided in two categories:

The Scala 3 compiler is able to rewrite existing source code to a different syntax.
Note that this rewriting is done one step at a time. In other words, rewriting to
the new significant indentation based syntax -and- to the new control structure syntax
the new significant indentation based syntax _and_ to the new control structure syntax
cannot be done in a single step.

Changing the syntax is a reversible process (except that after going back to where
Expand Down Expand Up @@ -42,7 +42,7 @@ alternative syntax options.
for a specific syntax rewrite.
- Note that syntax rewrites have to be executed one at a time. Also, consecutive
syntax rewrites have to be executed in a certain order. Make sure you understand
what's explained in the section named `Setting and Rewrites` at the end of the
what's explained in the section named `Settings and Rewrites` at the end of the
[Optional Braces](https://dotty.epfl.ch/docs/reference/other-new-features/indentation.html)
section in the Scala 3 reference documentation.

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ class ReductionRuleSuite extends munit.FunSuite with SudokuTestHelpers:
assertEquals(applyReductionRules(input), reducedInput)

test(
"Applying reduction rules should eliminate values in shadowed complete sets from occurrences in same cells (Second reduction rule)"):
"Applying reduction rules should eliminate values in shadowed complete sets from occurrences in the same cells (Second reduction rule)"):
val input = stringToReductionSet(
Vector(
"12 5 789", // (1,2,7,8) shadowed & complete
Expand Down Expand Up @@ -155,7 +155,7 @@ class ReductionRuleSuite extends munit.FunSuite with SudokuTestHelpers:
assertEquals(applyReductionRules(reducedInput1), reducedInput1)

test(
"Applying reduction rules should eliminate values in shadowed complete (6 value) sets from occurrences in same cells (Second reduction rule)"):
"Applying reduction rules should eliminate values in shadowed complete (6 value) sets from occurrences in the same cells (Second reduction rule)"):
val input = stringToReductionSet(
Vector(
"123456 89", // (1,2,3,4,5,6) shadowed & complete
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ class SudokuDetailProcessorSuite extends munit.FunSuite with SudokuTestHelpers:
override def afterAll(): Unit =
testKit.shutdownTestKit()

test("Sending no updates to a sudoku detail processor should result in sending a SudokuDetailUnchanged messsage"):
test("Sending no updates to a sudoku detail processor should result in sending a SudokuDetailUnchanged message"):

val probe = testKit.createTestProbe[SudokuDetailProcessor.Response]()
val detailProcessor = testKit.spawn(SudokuDetailProcessor[Row](id = 0))
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ class ReductionRuleSuite extends munit.FunSuite with SudokuTestHelpers:
assertEquals(applyReductionRules(input), reducedInput)

test(
"Applying reduction rules should eliminate values in shadowed complete sets from occurrences in same cells (Second reduction rule)"):
"Applying reduction rules should eliminate values in shadowed complete sets from occurrences in the same cells (Second reduction rule)"):
val input = stringToReductionSet(
Vector(
"12 5 789", // (1,2,7,8) shadowed & complete
Expand Down Expand Up @@ -155,7 +155,7 @@ class ReductionRuleSuite extends munit.FunSuite with SudokuTestHelpers:
assertEquals(applyReductionRules(reducedInput1), reducedInput1)

test(
"Applying reduction rules should eliminate values in shadowed complete (6 value) sets from occurrences in same cells (Second reduction rule)"):
"Applying reduction rules should eliminate values in shadowed complete (6 value) sets from occurrences in the same cells (Second reduction rule)"):
val input = stringToReductionSet(
Vector(
"123456 89", // (1,2,3,4,5,6) shadowed & complete
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ class SudokuDetailProcessorSuite extends munit.FunSuite with SudokuTestHelpers:
override def afterAll(): Unit =
testKit.shutdownTestKit()

test("Sending no updates to a sudoku detail processor should result in sending a SudokuDetailUnchanged messsage"):
test("Sending no updates to a sudoku detail processor should result in sending a SudokuDetailUnchanged message"):

val probe = testKit.createTestProbe[SudokuDetailProcessor.Response]()
val detailProcessor = testKit.spawn(SudokuDetailProcessor[Row](id = 0))
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ class ReductionRuleSuite extends munit.FunSuite with SudokuTestHelpers:
assertEquals(applyReductionRules(input), reducedInput)

test(
"Applying reduction rules should eliminate values in shadowed complete sets from occurrences in same cells (Second reduction rule)"):
"Applying reduction rules should eliminate values in shadowed complete sets from occurrences in the same cells (Second reduction rule)"):
val input = stringToReductionSet(
Vector(
"12 5 789", // (1,2,7,8) shadowed & complete
Expand Down Expand Up @@ -155,7 +155,7 @@ class ReductionRuleSuite extends munit.FunSuite with SudokuTestHelpers:
assertEquals(applyReductionRules(reducedInput1), reducedInput1)

test(
"Applying reduction rules should eliminate values in shadowed complete (6 value) sets from occurrences in same cells (Second reduction rule)"):
"Applying reduction rules should eliminate values in shadowed complete (6 value) sets from occurrences in the same cells (Second reduction rule)"):
val input = stringToReductionSet(
Vector(
"123456 89", // (1,2,3,4,5,6) shadowed & complete
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ class SudokuDetailProcessorSuite extends munit.FunSuite with SudokuTestHelpers:
override def afterAll(): Unit =
testKit.shutdownTestKit()

test("Sending no updates to a sudoku detail processor should result in sending a SudokuDetailUnchanged messsage"):
test("Sending no updates to a sudoku detail processor should result in sending a SudokuDetailUnchanged message"):

val probe = testKit.createTestProbe[SudokuDetailProcessor.Response]()
val detailProcessor = testKit.spawn(SudokuDetailProcessor[Row](id = 0))
Expand Down
4 changes: 2 additions & 2 deletions exercises/exercise_005_extension_methods/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -45,10 +45,10 @@ extension (i: Int)
## Steps - part I

You should look for extension methods defined with the Scala 2 syntax. How would
you approach this. As part of the exercise, you will define a few new extension
you approach this? As part of the exercise, you will define a few new extension
methods. In fact, for this exercise, the tests have been modified assuming these
new extension methods are already present. Let's start with adapting the existing
extension methods. Wait with running the tests until you start tackling the second
extension methods. Hold running the tests until you start tackling the second
part of this exercise (adding the new extension methods).

- Identify all extension methods defined using the _Scala 2 way_.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ class ReductionRuleSuite extends munit.FunSuite with SudokuTestHelpers:
assertEquals(applyReductionRules(input), reducedInput)

test(
"Applying reduction rules should eliminate values in shadowed complete sets from occurrences in same cells (Second reduction rule)"):
"Applying reduction rules should eliminate values in shadowed complete sets from occurrences in the same cells (Second reduction rule)"):
val input = stringToReductionSet(
Vector(
"12 5 789", // (1,2,7,8) shadowed & complete
Expand Down Expand Up @@ -155,7 +155,7 @@ class ReductionRuleSuite extends munit.FunSuite with SudokuTestHelpers:
assertEquals(applyReductionRules(reducedInput1), reducedInput1)

test(
"Applying reduction rules should eliminate values in shadowed complete (6 value) sets from occurrences in same cells (Second reduction rule)"):
"Applying reduction rules should eliminate values in shadowed complete (6 value) sets from occurrences in the same cells (Second reduction rule)"):
val input = stringToReductionSet(
Vector(
"123456 89", // (1,2,3,4,5,6) shadowed & complete
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ class SudokuDetailProcessorSuite extends munit.FunSuite with SudokuTestHelpers:
override def afterAll(): Unit =
testKit.shutdownTestKit()

test("Sending no updates to a sudoku detail processor should result in sending a SudokuDetailUnchanged messsage"):
test("Sending no updates to a sudoku detail processor should result in sending a SudokuDetailUnchanged message"):

val probe = testKit.createTestProbe[SudokuDetailProcessor.Response]()
val detailProcessor = testKit.spawn(SudokuDetailProcessor[Row](id = 0))
Expand Down
2 changes: 1 addition & 1 deletion exercises/exercise_006_using_and_summon/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ use of _scala 2_'s `implicit`s and `implicitly`.
> `Tip`: When a context parameter is passed explicitly it must be preceded by
> the `using` keyword
- Keep the `implicit`s at definition side for now, we can change them in the
- Keep the `implicit`s at definition side for now, we can change them in the
next exercise

- Replace all occurrences of `implicitly` with `summon`
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ class ReductionRuleSuite extends munit.FunSuite with SudokuTestHelpers:
assertEquals(applyReductionRules(input), reducedInput)

test(
"Applying reduction rules should eliminate values in shadowed complete sets from occurrences in same cells (Second reduction rule)"):
"Applying reduction rules should eliminate values in shadowed complete sets from occurrences in the same cells (Second reduction rule)"):
val input = stringToReductionSet(
Vector(
"12 5 789", // (1,2,7,8) shadowed & complete
Expand Down Expand Up @@ -155,7 +155,7 @@ class ReductionRuleSuite extends munit.FunSuite with SudokuTestHelpers:
assertEquals(applyReductionRules(reducedInput1), reducedInput1)

test(
"Applying reduction rules should eliminate values in shadowed complete (6 value) sets from occurrences in same cells (Second reduction rule)"):
"Applying reduction rules should eliminate values in shadowed complete (6 value) sets from occurrences in the same cells (Second reduction rule)"):
val input = stringToReductionSet(
Vector(
"123456 89", // (1,2,3,4,5,6) shadowed & complete
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ class SudokuDetailProcessorSuite extends munit.FunSuite with SudokuTestHelpers:
override def afterAll(): Unit =
testKit.shutdownTestKit()

test("Sending no updates to a sudoku detail processor should result in sending a SudokuDetailUnchanged messsage"):
test("Sending no updates to a sudoku detail processor should result in sending a SudokuDetailUnchanged message"):

val probe = testKit.createTestProbe[SudokuDetailProcessor.Response]()
val detailProcessor = testKit.spawn(SudokuDetailProcessor[Row](id = 0))
Expand Down
Loading

0 comments on commit 2f5f4fe

Please sign in to comment.