Oga support using Moxml #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suleman-uzair
force-pushed
the
update/support_oga_using_moxml
branch
from
e16aad6 to
9803e81
Compare
ronaldtse
reviewed
Jan 13, 2025
suleman-uzair
force-pushed
the
update/support_oga_using_moxml
branch
2 times, most recently
from
48115be to
1530550
Compare
suleman-uzair
force-pushed
the
update/support_oga_using_moxml
branch
from
21f5fb6 to
632be51
Compare
suleman-uzair
force-pushed
the
update/support_oga_using_moxml
branch
from
6b999a7 to
cace1a3
Compare
|
@suleman-uzair the termium gem is failing on 1 test. |
@ronaldtse, I looked into it, but @HassanAkbar had already opened a PR glossarist/termium#13 to fix this. |
I've released the updated termium gem. Hope it works! |
ronaldtse
approved these changes
Jan 31, 2025
|
@suleman-uzair could you please help rebase and merge this? Thanks! |
suleman-uzair
force-pushed
the
update/support_oga_using_moxml
branch
from
cace1a3 to
2f8f914
Compare
suleman-uzair
force-pushed
the
update/support_oga_using_moxml
branch
from
57232d8 to
692ba25
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves Oga implementation using Moxml.
closes #230
related to #227