-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Global Logging #172
Fix: Global Logging #172
Conversation
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #172 +/- ##
=========================================
+ Coverage 0 38.60% +38.60%
=========================================
Files 0 78 +78
Lines 0 4269 +4269
=========================================
+ Hits 0 1648 +1648
- Misses 0 2621 +2621 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM
Purpose
Previous setup of the logging module led to duplicit logs when using the Python
logging
module along thedepthai-nodes
package as a dependency.Specification
To get the package logger use the
get_logger
method fromdepthai_nodes.utils
.Dependencies & Potential Impact
All the files and classes that were using the logger were changed to use the package logger.
Testing & Validation
Was tested on simple script, where a custom logger was configured and log message from
depthai-nodes
was triggered. The logs were not duplicated bydepthai-nodes
logger. The logs fromdepthai-nodes
were successfully logged.