Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hub cleanup, token storage, readme #52

Merged
merged 7 commits into from
Nov 27, 2024
Merged

Hub cleanup, token storage, readme #52

merged 7 commits into from
Nov 27, 2024

Conversation

kozlov721
Copy link
Collaborator

Various small changes:

  • Some CLI cleanup
  • Updated README
  • Added modelconverter hub login command to securely store the API key on the system
    • So users don't need to figure out env variables for online conversion

@kozlov721 kozlov721 requested a review from a team as a code owner November 25, 2024 03:12
@kozlov721 kozlov721 requested review from klemen1999, tersekmatija and conorsim and removed request for a team November 25, 2024 03:12
Copy link
Collaborator

@klemen1999 klemen1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just left some comments

modelconverter/cli/types.py Show resolved Hide resolved
modelconverter/hub/__main__.py Show resolved Hide resolved
@kozlov721 kozlov721 merged commit b4180c3 into main Nov 27, 2024
1 check passed
@kozlov721 kozlov721 deleted the fix/conversion-api branch November 27, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants