Fix shutdown ordering to go after mounts are let go #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently on shutdown blk_availability will start almost as early as possible and invoke blkdeactivate. This can make devices and the filesystems on them unavailable that will still be needed by other parts of the shutdown. Usually such services needing the local filesystem will have declared After=local-fs.target And expect to be shut down before things are unmounted. But blkdeactivate might unmount things before all of that. To guarantee no devices / filesystems going away too early let us declare for blk_availability: Before=local-fs.target On shutdown that ensures that blkdeactivate will only be ordered after local-fs.target which seems what users would expect. Fixes: lvmteam#18 Signed-off-by: Christian Ehrhardt <[email protected]>
|
Hrm, the mirror seems to be out of date. Let me know if you want me to rebase to the master of https://github.com/lvmteam/lvm2.git or instead submit this somewhere else. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #18 this is a suggestion to fix the ordering issue on shutdown.