Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to disable examples apps #28

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add option to disable examples apps #28

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8cc1671
Add ability to disable example apps
MattIhnen Mar 7, 2024
0382126
Keep "option" lower case to be consistent with the rest of the cmake …
MattIhnen Mar 7, 2024
94d687d
Update option description to indicate linux instead of unix as per PR…
MattIhnen Mar 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,18 @@ set(LWIP_DIR ${CMAKE_CURRENT_SOURCE_DIR})

set (LWIP_DEFINITIONS LWIP_DEBUG=1)

if (${CMAKE_SYSTEM_NAME} STREQUAL "Windows")
add_subdirectory(${LWIP_DIR}/contrib/ports/win32/example_app)
elseif(${CMAKE_SYSTEM_NAME} STREQUAL "Linux" OR ${CMAKE_SYSTEM_NAME} STREQUAL "Darwin")
add_subdirectory(${LWIP_DIR}/contrib/ports/unix/example_app)
OPTION(LWIP_OPTION_ENABLE_EXAMPLE_APPS "Build example apps on win32/unix/darwin" ON)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be win32/linux/darwin not win32/unix/darwin, since unix is used for both Linux and Darwin.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DmitriiKostrov fixed in latest commit.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DmitriiKostrov Is there anything else that needs done to get this in? Been sitting 2 weeks now with no action.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, all looks fine for me. But I'm not a maintainer and cannot fully aprove it. Sorry


if (LWIP_OPTION_ENABLE_EXAMPLE_APPS)
if (${CMAKE_SYSTEM_NAME} STREQUAL "Windows")
add_subdirectory(${LWIP_DIR}/contrib/ports/win32/example_app)
elseif(${CMAKE_SYSTEM_NAME} STREQUAL "Linux" OR ${CMAKE_SYSTEM_NAME} STREQUAL "Darwin")
add_subdirectory(${LWIP_DIR}/contrib/ports/unix/example_app)
else()
message(WARNING "Host ${CMAKE_SYSTEM_NAME} is not supported to build example_app")
endif()
else()
message(WARNING "Host ${CMAKE_SYSTEM_NAME} is not supported to build example_app")
message(STATUS "example_app build disabled")
endif()

# Source package generation
Expand Down