Make NewLoader accept a pointer (#167)

* Make NewLoader accept a pointer * Fix test
m-lab · Mar 28, 2023 · 8b6a257 · 8b6a257
1 parent e27f60e
commit 8b6a257
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/cloudtest/bqfake/bqfake.go b/cloudtest/bqfake/bqfake.go
@@ -200,12 +200,12 @@ func (q Query) Read(context.Context) (bqiface.RowIterator, error) {
 // Loader implements parts of bqiface.Loader to allow for testing.
 type Loader struct {
 	bqiface.Loader
-	job Job
+	job *Job
 	err error
 }
 
 // NewLoader returns a new instance of Loader.
-func NewLoader(job Job, err error) *Loader {
+func NewLoader(job *Job, err error) *Loader {
 	return &Loader{
 		job: job,
 		err: err,

diff --git a/cloudtest/bqfake/bqfake_test.go b/cloudtest/bqfake/bqfake_test.go
@@ -280,7 +280,7 @@ func TestTableUpdate(t *testing.T) {
 }
 
 func TestTableLoaderFrom(t *testing.T) {
-	ldr := bqfake.NewLoader(bqfake.Job{}, nil)
+	ldr := bqfake.NewLoader(&bqfake.Job{}, nil)
 	tbl := bqfake.NewTable(bqfake.TableOpts{
 		Loader: ldr,
 	})
@@ -386,7 +386,7 @@ func TestNewQueryReadClient(t *testing.T) {
 }
 
 func TestLoaderRun(t *testing.T) {
-	job := bqfake.Job{}
+	job := &bqfake.Job{}
 	err := errors.New("loader error")
 	ldr := bqfake.NewLoader(job, err)
 	got, gotErr := ldr.Run(context.Background())